`appmode` with pip installed extension about appmode

[oschuett]

I just released Appmode 0.3.0 and I decided to include the patch for this issue after all. Hopefully, this minimizes the trouble for everybody else once Jupyter notebook make their release.

[oschuett]

Hi, which version of Jupyter are you using?

[epifanio]

jupyter --version
4.4.0

[oschuett]

So, I think the root cause is this recent commit: jupyter/notebook@198d74a. It added a new argument get_custom_frontend_exporters to the render_template() call is which replicated in Appmode .

What's puzzling me though is that you are already using this code, because it is only in the master branch and not yet in 5.4.x branch. Therefore, it is also not part of the latest release.

I will however have to adopt Appmode soon. So, thanks for the early warning :-)

[epifanio]

yes, true most of my system runs on git:master branch for the main repository. I'll keep an eye on your changes and install appmode from git:master as well. Thanks!

[oschuett]

Before I adopt Appmode, I would like to wait until this change actually gets released by the notebook project. In the meantime I would suggest that you patch server_extension.py yourself. It should look kinda like this (haven't tested it):

 from notebook.notebook.handlers import get_custom_frontend_exporters     # new line
...
 self.write(self.render_template('appmode.html',
            notebook_path=tmp_path,
            notebook_name=tmp_name,
            kill_kernel=False,
            mathjax_url=self.mathjax_url,
            mathjax_config=self.mathjax_config,
            get_custom_frontend_exporters=get_custom_frontend_exporters,  # new line
            )
 )

[epifanio]

Applied the patch, it works great!
on both single user notebook and multiuser jupyterhub.
Thanks!