Comments (10)
Same not-null in java client https://github.com/ory/sdk/blob/master/clients/kratos/java/src/main/java/sh/ory/kratos/model/VerifiableAddress.java. But kratos api can return null
from sdk.
I checked swagger schema, verified_at
is NullTime
. I think it is ok and need some generator hacks
from sdk.
Seems like OpenAPITools/openapi-generator#4816 OpenAPITools/openapi-generator#3725
from sdk.
@aeneasr I think that NullTime might be marked as nullable: true
or x-nullable: true
(it might not work)
Some conditions for property nullability:
https://github.com/OpenAPITools/openapi-generator/pull/3537/files
https://github.com/OpenAPITools/openapi-generator/blob/2331432cc0f062ceff44c3d09e1a16c31abf6f57/modules/openapi-generator/src/main/java/org/openapitools/codegen/utils/ModelUtils.java#L1419
from sdk.
Interesting...
Ts client has nullable verified_at
sdk/clients/kratos/typescript/api.ts
Line 1045 in 00fc86e
from sdk.
We are moving to OpenAPI 3.0 which hopefully improves this situation. However, it is also possible that the generator is buggy for the language.
from sdk.
I am still having this issue, with
<PackageReference Include="Ory.Kratos.Client" Version="0.7.6-alpha.7" />
Error converting value {null} to type 'System.DateTime'. Path 'identity.verifiable_addresses[0].verified_at', line 1, position 615.
(also the exceptionfactory here seems to produce null exception, so the function doesnt throw like it probably should, I just get null response from toSession
, had to step into the function to spot the actual exception
Exception exception = this.ExceptionFactory("ToSession", (IApiResponse) apiResponse);
if (exception != null)
throw exception;
)
(From KratosVerifiableIdentityAddress.cs
/// <summary>Gets or Sets VerifiedAt</summary>
/// <footer><a href="https://www.google.com/search?q=Ory.Kratos.Client.Model.KratosVerifiableIdentityAddress.VerifiedAt">`KratosVerifiableIdentityAddress.VerifiedAt` on google.com</a></footer>
[DataMember(EmitDefaultValue = false, Name = "verified_at")]
public DateTime VerifiedAt { get; set; }
)
Seems this will be fixed in kratos v0.8? ory/kratos#1736
from sdk.
Kratos 0.8 is being released today (pipeline is running). Hopefully it gets fixed then. Maybe you can comment and keep us updated? :)
from sdk.
Yes it worked without issues in 0.8 👍
from sdk.
wohooo!
from sdk.
Related Issues (20)
- BC breaks: fields in the SDK changed (e.g. FrontendApi > FrontendAPI; IdentityApi > IdentityAPI) HOT 5
- ory client-go 1.6.1: cannot deserialize continue_with response HOT 3
- [Rust] update_registration_flow error handling HOT 1
- Getting error in the response of "createNativeRegistrationFlow" API : Social Sign In and OpenID Connect are only supported for flows initiated using the Browser endpoint
- .NET packages have not been updated HOT 1
- dotnet clients on nuget.com not updated since ~3 months HOT 6
- UnmarshalJSON fails for the LoginFlow type in kratos-client-go
- Elixir deps can't be compiled HOT 1
- v1.11.6 adds axios to @ory/client-fetch HOT 2
- Elixir API client deserialisation error when parsing enum values HOT 2
- Ruby generator generates invalid code due to Cookie Auth in spec HOT 1
- CI fails when trying to publish client HOT 1
- Ory client side libraries should be Tree Shakeable HOT 3
- Publish Java kratos-client 1.2 to maven central HOT 1
- upstream reference closed: github.com/gradle/gradle/issues/25036
- upstream reference closed: github.com/guzzle/psr7/pull/603
- Publish Rust crate v1.2.x
- Keto typescript fetch client HOT 2
- Publish Dart Client with Kratos v1.2.x HOT 1
- Package published to pub.dev is outdated HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdk.