[Helm] Ensure kubernetes version label is always present about k8s

[aeneasr]

Oh ok, I see - the current way this is generated is simply from helm create . so there's definitely room for improvement!

[aeneasr]

What exactly is the issue here? You can check out the release pipeline here: https://github.com/ory/k8s/blob/master/.circleci/config.yml#L14

[ermik]

This doesn't refer to build artifacts, rather it is one of best practices to include labels (annotations) to the generated manifests explicitly, rather than relying on other tools in the deployment pipeline (Tiller, kubelet) to write them when manifests are applied in the cluster.

This issue can be closed by adding a .tpl partial with something like the following:

{{- define "labels.app"}}
app: {{ .Chart.Name | quote }}
{{- end }}
{{- define "labels.version" }}{{- $serviceVersion := printf "v%s" .Chart.Version }}
version: {{ $serviceVersion | quote }}
{{- end }}
{{- define "labels.helm" }}
chart: {{ printf "%s-%s" .Chart.Name (.Chart.Version | replace "+" "_") | quote }}
release: {{ .Release.Name | quote }}
heritage: {{ .Release.Service | quote }}
{{- end }}

and using this partial in the following way:

  name: {{ .Values.somename | quote }}
  labels:
    {{- include "labels.app" . | indent 4 }}
    {{- include "labels.version" . | indent 4 }}
    {{- include "labels.helm" . | indent 4 }}

in each of the templated objects.

There are more annotations that are suggested in best practices, but helm.sh and app/version are ones I (personally) think are important.

[ermik]

I took another look and I see that I missed some of the work that has already been done. Additionally, the example above shows classic labels — I linked to current best practices to avoid confusion. I've reformatted this issue to make sure it's clearer and published the PR implementing the changes.