Coder Social home page Coder Social logo

Comments (3)

aeneasr avatar aeneasr commented on April 28, 2024

I think that it is easier to filter out the Authorization http header in logs instead of filtering specific values in bodies like client_id or client_secret. Otherwise I do not know why this method is not recommended.

I realize that some libraries implement faulty behaviour which is why I wrote this library here. I'd rather not include a fallback as I'm trying to follow all the good practices the IETF recommends.

Let me know if you disagree, I'm open for discussion! :)

from fosite.

cristiangraz avatar cristiangraz commented on April 28, 2024

I was actually thinking the same thing -- and not really sure why a client wouldn't be able to send an Authorization header. More of an inconvenience with the rest client I'm using, but I agree this library is stricter than most (which is what I like about it!) and should avoid everything but best practices. Thanks for chiming in so quickly!

from fosite.

aeneasr avatar aeneasr commented on April 28, 2024

Sure, thanks for your thoughts, feedback and contributions! I appreciate it!

from fosite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.