Comments (6)
Thanks for reporting.
I had a quick look: a stray <span id="fb-root"></span>
in the <head>
on that site seems to trick the parser into thinking the <body>
has started. The people downstream at the html5ever project may be interested in picking that up.
My library only picks up the meta info that is actually located in the <head>
.
I could change that to look in the body as well, but that should be opt-in. Would that work for you?
from webpage-rs.
Using an opt-in is no problem, assuming that there are no negative side effects.
And im not familiar with html5ever, so not sure how it relates.
from webpage-rs.
Okay, I can pick this up next week. Feel free to open a PR if you are in a hurry
from webpage-rs.
I've got little idea how this actually works, but maybe it would make sense to trigger searching in the body if no data is found in the head? (original reporter here)
Unless the problem is multiple matching tags, which I guess might be what's going on with the charset on some of such pages for example;
https://wyborcza.biz/biznes/7,147582,28355528,klasa-srednia-zaciska-pasa.html?squid_js=false
has
<script src="[https://cdn.cookielaw.org/scripttemplates/otSDKStub.js](view-source:https://cdn.cookielaw.org/scripttemplates/otSDKStub.js)" type="text/javascript" charset="UTF-8" data-domain-script="109023
before we arrive at the actual
<meta charset="ISO-8859-2">
so we end up with something like this on our page;
(and that's one of the biggest news media in Poland, not some random small things, dont ask me why would anyone still use ISO charsets)
from webpage-rs.
Not sure if I should open another issue, but Lemmy doesn't seem to get images from root-relative URLs like this one: <meta property="og:image" content="/wp-content/uploads/2023/06/JavaScript-modificando-el-portapapeles.png">
. I didn't test if this library is the problem or just Lemmy, because I don't know Rust. Other programs like Telegram, Postmill, Mastodon and Facebook can display the image of root-relative URLs when shared.
Here you can find such og:image
to make tests: https://freakspot.net/eo/eviti-ke-%C4%9Cavoskripto-modifu-la-tondujon/
from webpage-rs.
Thanks for bringing this to my attention @jorgesumle
This library only lists the opengraph fields as-is, and it is lemmy that then tries to fetch the listed URLs, so I think it is up to lemmy to resolve the URLs properly. I created a PR on the lemmy repo for it. Perhaps you can vouch for it over there!
Leaving this issue open to address the original issue. That should be fixed on my part.
from webpage-rs.
Related Issues (11)
- Error when trying to parse HTML directly without going through a webpage
- build fail wasm-pack build --target web after adding webpage HOT 1
- Can't fetch schema.org data if it contains "@graph" HOT 1
- Feature request: Allow adding headers to WebpageOptions HOT 3
- Clean up mod layout
- Feature request: links included in HTML HOT 3
- Mark more structs `non_exhaustive`
- Clone? HOT 1
- Serialization HOT 2
- Non-ascii host/domain names are not handled properly HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webpage-rs.