Comments (14)
I was thinking we bump it up to 1e-5 percent and may be check that absolute difference is less than 1 microvolt
from cap.
On jenkins
GIT_COMMIT_HASH=6bfffde034c545d56c450e1e43316966a7fbc1be
GIT_REMOTE_URL=https://github.com/ORNL-CEES/Cap
[...]
Total Test time (real) = 27.89 sec
The following tests FAILED:
11 - test_exact_transient_solution_cpp_1_procs (Failed)
Errors while running CTest
from cap.
I use a percent tolerance of 1e-3.
from cap.
Running 1 test case...
/home/jenkins/workspace/Bar/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{4.29972e-06} between computed_voltage{0.17259069351540293} and gold_solution[pos]{0.17259143560676579} exceeds 1e-05%
/home/jenkins/workspace/Bar/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{2.04154e-06} between computed_voltage{0.18593225566221308} and gold_solution[pos]{0.18593263524951811} exceeds 1e-05%
/home/jenkins/workspace/Bar/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{2.36768e-06} between computed_voltage{0.19059739274508819} and gold_solution[pos]{0.19059784401880361} exceeds 1e-05%
/home/jenkins/workspace/Bar/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{1.16667e-06} between computed_voltage{0.19460198487156083} and gold_solution[pos]{0.1946022119085378} exceeds 1e-05%
/home/jenkins/workspace/Bar/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{3.79018e-06} between computed_voltage{0.19815937216959012} and gold_solution[pos]{0.19816012322872489} exceeds 1e-05%
/home/jenkins/workspace/Bar/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{6.66338e-07} between computed_voltage{0.20139353082879491} and gold_solution[pos]{0.2013936650249285} exceeds 1e-05%
/home/jenkins/workspace/Bar/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{1.78799e-06} between computed_voltage{0.20438036420913069} and gold_solution[pos]{0.20438072963998949} exceeds 1e-05%
/home/jenkins/workspace/Bar/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{2.34171e-06} between computed_voltage{0.20716968626261728} and gold_solution[pos]{0.2071701713934283} exceeds 1e-05%
/home/jenkins/workspace/Bar/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{8.27384e-07} between computed_voltage{0.20979775467086972} and gold_solution[pos]{0.20979792825420379} exceeds 1e-05%
*** 9 failures are detected in the test module "ExactTransientSolution"
from cap.
it's insane it shouldn't have passed the BOOST_CHECK_SMALL with 1microvolt of tolerance...
from cap.
copy/paste from discussion on PR #123
test_exact_transient_solution_cpp_1_procs" start time: Apr 21 09:31 EDT
Output:
Running 1 test case...
/home/bt2/Documents/Cap/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{2.36184e-06} between computed_voltage{0.17259184323958501} and gold_solution[pos]{0.17259143560676579} exceeds 1e-05%
/home/bt2/Documents/Cap/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{1.74836e-07} between computed_voltage{0.18020259512043804} and gold_solution[pos]{0.18020256361459411} exceeds 1e-05%
/home/bt2/Documents/Cap/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{1.10821e-06} between computed_voltage{0.18593242919793684} and gold_solution[pos]{0.18593263524951811} exceeds 1e-05%
/home/bt2/Documents/Cap/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{9.04486e-07} between computed_voltage{0.1905976716258401} and gold_solution[pos]{0.19059784401880361} exceeds 1e-05%
/home/bt2/Documents/Cap/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{1.15416e-07} between computed_voltage{0.19460223436876695} and gold_solution[pos]{0.1946022119085378} exceeds 1e-05%
/home/bt2/Documents/Cap/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{2.77022e-06} between computed_voltage{0.19815957428217496} and gold_solution[pos]{0.19816012322872489} exceeds 1e-05%
/home/bt2/Documents/Cap/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{1.16931e-06} between computed_voltage{0.20139390051686604} and gold_solution[pos]{0.2013936650249285} exceeds 1e-05%
/home/bt2/Documents/Cap/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{1.39484e-06} between computed_voltage{0.20438101471750267} and gold_solution[pos]{0.20438072963998949} exceeds 1e-05%
/home/bt2/Documents/Cap/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{1.36566e-06} between computed_voltage{0.20717045431816833} and gold_solution[pos]{0.2071701713934283} exceeds 1e-05%
/home/bt2/Documents/Cap/cpp/test/test_exact_transient_solution.cc(68): error: in "test_exact_transient_solution": difference{1.02468e-06} between computed_voltage{0.20979771327799024} and gold_solution[pos]{0.20979792825420379} exceeds 1e-05%
from cap.
How does 1e-6 exceed 1e-5?
from cap.
It is a total non sense, the test that should be failing is not the BOOST_CHECK_CLOSE
but the BOOST_CHECK_SMALL
...
from cap.
1e-6 > 1e-5% = 1e-7
from cap.
What is the commit hash?
from cap.
Oh yes percentage you are right
from cap.
But shouldn't the BOOST_CHECK_SMALL
fail as well?
from cap.
OK I get it now.
Let's relax to 1e-3%
from cap.
The issue is addressed in PR #119 which should be merged shortly
from cap.
Related Issues (20)
- Build broken on Travis CI HOT 8
- Remove dependance on cap-data HOT 1
- Geometry
- Equation system HOT 1
- Update pre-built image HOT 2
- Destructor called twice HOT 1
- test waffle
- test waffle 2
- Bug in 3D
- Compilation of Cap depends on the name of branch HOT 1
- Postprocessor HOT 3
- Error catch within ragone_plot.py HOT 8
- Add installation guidelines to install the full software stack using Spack HOT 1
- Python coverage on the plotting utilities
- Docker enhancements HOT 2
- suppress warnings HOT 1
- Make diff-clang-format.py runnable from source directory HOT 4
- Document inputs
- Bug: current version won't build if deal.II is not enabled
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cap.