Subscription Product / Payment Support (OCC-59) about orchardcore.commerce

[MikeAlhayek]

Another benefit from relying on the provider to handler subscription, is other apps can also hook in the event. For example, OC App, sends a request to create a customer then create a subscription, other app can act on the subscription request.

[Piedone]

A better term would have been "normalization of the data" that we should resist :). But great then!

[Piedone]

By default, the Subscription simply continues on with the pricing as it was fixed in time at the Order, it does not recalculate pricing along the way.

This is very important: Here we need to resist an attempt to DRY and load the corresponding pricing details on the fly, because changes to those shouldn't affect ongoing subscriptions.

For issuing the subscription, it should be noted that depending on the payment provider's capabilities, there can be two approaches:

1. The payment provider attempts the subscription periodically and notifies the app about the results via a webhook. This means that the configuration of the subscription should be sent to the payment provider.
2. The app attempts to issue the charge periodically.

If possible, the first approach would be better, since that's what surely works with all cards (including MFA with 3DS2). I'm not even sure that the second approach is in line with regulations.

[Piedone]

Also, we'd need to allow users to change their subscription: e.g. change between monthly and yearly payments, and subscription tiers.

[sarahelsaig]

Here we need to resist an attempt to DRY and load the corresponding pricing details on the fly, because changes to those shouldn't affect ongoing subscriptions.

Never resist an attempt to DRY. :) The Order's line items already have baked-in prices for the same reason, so you can always use the first order as reference if necessary.

[sarahelsaig]

It came to my mind that if the automatic payment from the payment provider's side fails or the subscription is removed from their end, we should still generate a "pending" order and send a mail to the customer. Same in case of payment providers without subscription support. This ties into #345 because right now you can only pay during checkout.