Transformations don't work with array attributes about ember-orbit

[dgeb]

I think checking path.length has been a naive approach. It would probably be better to check the contents of path[2] to verify whether a link or attribute is being updated. There is similar logic in some orbit sources that should be improved as well.

[tute]

Interesting. I tried something like that, and it did propagate the didTransform properly, but the array still was being changed in very weird ways until resulting in a number (losing the other values), probably because of other places where there's similar logic.

I'll keep your comment in mind for an upcoming PR.

[dgeb]

@tute Looking at this in more detail, it appears that you must be trying to patch within an attribute that's an array. If you were simply replacing an attribute whose value is an array, then path.length would still be 3.

I'm going to close this for now, since I don't plan to support patching embedded arrays or objects, except as a whole. Of course, I'm open to discussion of why Orbit might want to support micro-patches of embedded data as opposed to normalizing the embedded data out into separate models and relationships. Please let me know your use case if you want to pursue this. Thanks!

[tute]

Sounds good @dgeb, thanks for your work! Your idea of a model object that takes care of updating the array/object argument makes a lot of sense and works great!

[dgeb]

@tute ok, cool - thanks for confirming that this approach will work for you!