Comments (5)
I think checking path.length
has been a naive approach. It would probably be better to check the contents of path[2]
to verify whether a link or attribute is being updated. There is similar logic in some orbit sources that should be improved as well.
from ember-orbit.
Interesting. I tried something like that, and it did propagate the didTransform
properly, but the array still was being changed in very weird ways until resulting in a number (losing the other values), probably because of other places where there's similar logic.
I'll keep your comment in mind for an upcoming PR.
from ember-orbit.
@tute Looking at this in more detail, it appears that you must be trying to patch within an attribute that's an array. If you were simply replacing an attribute whose value is an array, then path.length
would still be 3.
I'm going to close this for now, since I don't plan to support patching embedded arrays or objects, except as a whole. Of course, I'm open to discussion of why Orbit might want to support micro-patches of embedded data as opposed to normalizing the embedded data out into separate models and relationships. Please let me know your use case if you want to pursue this. Thanks!
from ember-orbit.
Sounds good @dgeb, thanks for your work! Your idea of a model object that takes care of updating the array/object argument makes a lot of sense and works great!
from ember-orbit.
@tute ok, cool - thanks for confirming that this approach will work for you!
from ember-orbit.
Related Issues (20)
- TS issues HOT 2
- Dependencies not defined in ember-orbit, like @orbit/local-storage-bucket not propagated through addons HOT 1
- Adding a validation function to the data models in orbit HOT 2
- Merging a fork when using IndexedDb causes error HOT 3
- Integrating with newer test waiters system HOT 5
- Provide better integration with Ember's new test waiters system
- Throws unintended exception while trying to assert about hasMany with no arg HOT 1
- Best pattern for load+fork HOT 4
- Synchronous in-memory addRecord HOT 4
- Detecting yet-to-be-loaded models HOT 4
- IndexedDB error adding new model type HOT 4
- [Beta 15] Removed from cache errors HOT 7
- Improve handling of bucket injections for ember v4 compat.
- Upgrading to 0.17 with custom serializers HOT 1
- No 'attributes' saved to indexeddb HOT 1
- Access to relationships.*.data.id HOT 3
- Irregular noun record type doesn't sync to store HOT 4
- The get attribute cache lookup error is hard to debug
- Included ( second level ) data is not passing through Orbit if they are not cached !
- Typescript compatibility issues HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-orbit.