Polymorphic JSON support made some objects extremely difficult to use about oci-go-sdk

[jhorwit2]

In order to use VolumeAttachmentDetails I had to copy the private struct into my project.

type AttachVolumeDetails struct {
	InstanceID  *string `mandatory:"true" json:"instanceId,omitempty"`
	VolumeID    *string `mandatory:"true" json:"volumeId,omitempty"`
	DisplayName *string `mandatory:"false" json:"displayName,omitempty"`
	Type        string  `json:"type"`
}

func (m AttachVolumeDetails) GetInstanceID() *string {
	return m.InstanceID
}
func (m AttachVolumeDetails) GetVolumeID() *string {
	return m.VolumeID
}
func (m AttachVolumeDetails) GetDisplayName() *string {
	return m.DisplayName
}

so I could call

coreClient.AttachVolume(ctx, core.AttachVolumeRequest{
	AttachVolumeDetails: AttachVolumeDetails{
		InstanceID:  &instance.Status.ID,
		VolumeID:    &instance.Status.VolumeID,
		DisplayName: &instance.Name,
	},
})

[eginez]

Hi @jhorwit2, yes the documentation is a little light on this, I apologize.
Per the specificiation of the the service AttachVolumeDetails is polymorphic parameter that should at least contain the values listed in the interface.

Currently the only input parameter that the compute service supports for this call is the AttachIScsiVolumeDetails struct. AttachIScsiVolumeDetails implements the AttachVolumeDetails interface, thus you should not need access to the private structure

Your call could look like this:

core.AttachVolumeRequest(ctx,  core.AttachVolumeRequest{
                AttachVolumeDetails: core.AttachIScsiVolumeDetails{
		        InstanceID:  common.String("id"),
		        VolumeID:    common.String("volume"),
		        DisplayName: common.String("display"),
		        UseChap:     common.Bool(false),
	}
}