Coder Social home page Coder Social logo

Comments (6)

jasonyin avatar jasonyin commented on June 14, 2024

hi @jhorwit2, thanks for reporting this issue. The opc-request-id is defined in most response structs (if defined by the spec), are you referring to the case of service failure, add this id to the error?

from oci-go-sdk.

jhorwit2 avatar jhorwit2 commented on June 14, 2024

Yes @jasonyin

from oci-go-sdk.

jhorwit2 avatar jhorwit2 commented on June 14, 2024

@jasonyin i have a fork with this functionality since i need it for an SR. If you want I can open up a PR?

from oci-go-sdk.

jasonyin avatar jasonyin commented on June 14, 2024

this is been fixed in v2.1.0 https://github.com/oracle/oci-go-sdk/releases/tag/v2.1.0
the common.ServiceError now have a method GetOpcRequestID()

from oci-go-sdk.

jhorwit2 avatar jhorwit2 commented on June 14, 2024

@jasonyin that code looks potentially like it can panic. You're checking if ociResponse isn't nil on error then assuming in newServiceFailureFromResponse that it's always not nil.

from oci-go-sdk.

jhorwit2 avatar jhorwit2 commented on June 14, 2024

Nvm.

from oci-go-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.