Coder Social home page Coder Social logo

Comments (3)

certaintls avatar certaintls commented on May 22, 2024

I see go.mod and go.sum are in .gitingore . They should be committed. See https://stackoverflow.com/a/53852916/1966269

from shapeshifter-dispatcher.

consuelita avatar consuelita commented on May 22, 2024

Thank you for catching this. The .gitignore has been corrected and go.mod and go.sum are both present and accounted for. This will be included in the next release.

from shapeshifter-dispatcher.

blanu avatar blanu commented on May 22, 2024

While we are happy to make this change and add the go.sum back because you have requested us to do so, I wanted to comment that this was not a mistake, but rather a philosophical agreement on whether go.sum files should be committed. The origin of this "best practice" in Go is from the Golang FAQ, which references a single Tweet, "FAQ: Should I check go.sum into git? A: Generally yes. With it, anyone with your sources doesn't have to trust other GitHub repositories and custom import path owners. Something better is coming, but in the meantime it's the same model as hashes in lock files." (https://twitter.com/FiloSottile/status/1029404663358087173)

In our experience as a team, the particular way that go.sum files are implemented causes more problems than it adds in value. My recommendation is therefore to not add go.sum files to git unless you have a specific reason to do so. In this case, our reason to do so is that a user has requested that we provide go.sum files, which is a good enough reason for me.

from shapeshifter-dispatcher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.