Comments (3)
I see go.mod and go.sum are in .gitingore . They should be committed. See https://stackoverflow.com/a/53852916/1966269
from shapeshifter-dispatcher.
Thank you for catching this. The .gitignore has been corrected and go.mod and go.sum are both present and accounted for. This will be included in the next release.
from shapeshifter-dispatcher.
While we are happy to make this change and add the go.sum back because you have requested us to do so, I wanted to comment that this was not a mistake, but rather a philosophical agreement on whether go.sum files should be committed. The origin of this "best practice" in Go is from the Golang FAQ, which references a single Tweet, "FAQ: Should I check go.sum into git? A: Generally yes. With it, anyone with your sources doesn't have to trust other GitHub repositories and custom import path owners. Something better is coming, but in the meantime it's the same model as hashes in lock files." (https://twitter.com/FiloSottile/status/1029404663358087173)
In our experience as a team, the particular way that go.sum files are implemented causes more problems than it adds in value. My recommendation is therefore to not add go.sum files to git unless you have a specific reason to do so. In this case, our reason to do so is that a user has requested that we provide go.sum files, which is a good enough reason for me.
from shapeshifter-dispatcher.
Related Issues (20)
- Inconsistent iat documentation and handling HOT 1
- unknow field 'Dialer' HOT 3
- Consider tagging releases HOT 4
- Segmentation Fault on Kubuntu HOT 1
- Support hostnames when specifying hosts HOT 2
- -transparent -udp option not working? binding to TCP port instead HOT 1
- Error: module declares its path as: monolith, but was required as: monolith-go/monolith HOT 1
- shapeshifter-dispatcher fails to compile: addInstance.Bytes undefined HOT 2
- Unable to dial transport server: failed to decode cert: illegal base64 data at input byte 0 HOT 1
- Problem with UDP transparent mode HOT 2
- Should shapeshifter-dispatcher have a CI? HOT 2
- connections never closed
- [bug] meekserver and meeklite transport error
- slice bounds out of range [:16] with capacity 0 HOT 1
- Decide if this project should be the one to help PT get off the island
- shapeshifter-dispatcher does not open any port on debian 11 server HOT 1
- go install failing due to go.mod version mismatch? HOT 2
- Received an error while attempting to accept a connection:clientConfirmationCode and server copy not equal HOT 5
- CopyServerToClient received an error: read: i/o timeout
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shapeshifter-dispatcher.