Coder Social home page Coder Social logo

Comments (6)

hongchaodeng avatar hongchaodeng commented on June 10, 2024

It depends.
For the behavior, if the input is deterministic, and output is deterministic, then it is safe to skip anything that already exists.

if app-operator folder has been created already

IMHO, this is not enough to determine if the output is what we want to generate.

from operator-sdk.

hasbro17 avatar hasbro17 commented on June 10, 2024

this is not enough to determine if the output is what we want to generate

@hongchaodeng Can you explain your concern a bit more.

I was thinking that the expected behavior from operator-sdk new <project-name> is to simply create a new project if it does not exist.
So there are two cases:

  • If a directory with <project-name> already exists in the current working directory then the command should output an error saying it already exists. Doesn't matter are the contents of that directory.
  • If there is no directory, then create a new project.

from operator-sdk.

hongchaodeng avatar hongchaodeng commented on June 10, 2024

I think the solution @hasbro17 mentioned above is good enough.

Can you explain your concern a bit more.

Not really a concern. As mentioned above, in order to skip some files and generate the rest, it needs both the input and output to be deterministic. Just checking the folder exists not enough.

from operator-sdk.

hasbro17 avatar hasbro17 commented on June 10, 2024

Sounds good. @fanminshi We'll proceed with the above mentioned behavior for now.

from operator-sdk.

fanminshi avatar fanminshi commented on June 10, 2024

yep!

from operator-sdk.

fanminshi avatar fanminshi commented on June 10, 2024

fixed via #85

from operator-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.