why CombinedOutput instead of cmd.Output? about audit

[camilamacedo86]

Hi @fgiloux,

That was used to get the result combined. Note that CombinedOutput runs a command and returns combined stdout and stderr. However, please feel free to propose changes to it as you see fits.

[camilamacedo86]

Hi @fgiloux,

Is this issue still required or we can close this one?

[fgiloux]

Hi @camilamacedo86. I don't think the issue disappeared. As soon as the container engine generates warnings things get broken

[camilamacedo86]

@fgiloux so, what exactly brokes?

If > if err := json.Unmarshal(output, &dockerInspect); err != nil {
fails then the error would be added to audit.errors and we have this data in the report

[fgiloux]

@camilamacedo86 the thing is that Unmarshal will not only fail when you have an error but also when the container engine outputs whatever message, like a warning that may not prevent the processing but now does because it is no proper json