context lost when tracing mongodb? about zipkin-js

[codefromthecrypt]

keep open for now as I have another topic we need to resolve which is explicit use of contexts inside instrumentation (ex tracer.record(id, annotation)) which can help guarantee less loss of events.

[hafeyang]

anyone can pr mongodb instrumentation ? I am confused.

[codefromthecrypt]

Maybe do a github search to see if anyone else is making custom tracing for mongo using zipkin-js?

…

On 15 Apr 2017 12:03 am, "阳衡锋" ***@***.***> wrote: anyone can pr mongodb instruments ? I am confused. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#101 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD616TgJUWkWFu4UQ_e9c2uYl3LhdKcks5rv5i2gaJpZM4M8iNL> .

[codefromthecrypt]

I looked around and found almost universally people are instrumenting mongodb with a shimmer of some sort.

[embs]

@adriancole

1. what do you mean by a shimmer of some sort?
2. do you think this project would be a good option for zipkin-mongo instrumentation? https://github.com/abesto/zipkin-mongodb

Thanks!

[jcchavezs]

Worth to revisit this @adriancole ?