error occurs when build example because of thrift about zipkin-go-opentracing

[sitano]

@andream16 you can make it work with pinning the thrift version in your deps (glide or whatever) to something working like:

- package: github.com/apache/thrift
  version: a533ea1615e9df935e77b99440cf264c6b417e3e

[jcchavezs]

@andream16 you can go to your $GOPATH/src/github.com/apache/thrift and there do git checkout a533ea1615e9df935e77b99440cf264c6b417e3e. Another solution is this one which is waiting to be merged.

[cc5092]

Add another picture by go get github.com/openzipkin/zipkin-go-opentracing

[kujtimiihoxha]

I can confirm ^ also

[codefromthecrypt]

I just kicked off the build again, which indeed breaks
https://travis-ci.org/openzipkin/zipkin-go-opentracing/builds/290589542

Can someone follow-up with this? for example raise a PR?

[codefromthecrypt]

Also a bit curious if folks are actually using the scribe transport or not, or if this is just a problem building the project. For example, if you aren't conflicting because you use thrift, perhaps there's a way to not use the trunk version of thrift.

(I have no idea what dependency hygiene looks like in go world, so forgive me in advance if this isn't a relevant suggestion)

[kujtimiihoxha]

I am not using thrift at all, it is just a problem while building. (I am using go-kit, it uses this library)

[kujtimiihoxha]

@adriancole here you go #87

[jcchavezs]

This PR solves the actual problem #88

@adriancole @basvanbeek

[sitano]

it's a shame it depends on some middle version in between thrift 0.11.0 and the latest, and it does not compatible to either one. apache thrift broke backward compatibility at 4f77ab8e296d64c57e6ea1c6e3f0f152bc7d6a3a.

[andream16]

When will it be merged? I really need this issue to get fixed. I cannot run any go-kit example.

[andream16]

Solved, thanks guys.

[basvanbeek]

updated the generated thrift code in #90 and tests pass again