Coder Social home page Coder Social logo

Comments (5)

basvanbeek avatar basvanbeek commented on June 18, 2024

As all the code under _thrift is generated I specifically prefixed with _ so it would not be included in tests, coverage, linting, etc.

Seems GVT includes omitting behavior to extend to pulling in code too which is rather strange as one would expect the VC to not include items that should be ignored.

from zipkin-go-opentracing.

igorwwwwwwwwwwwwwwwwwwww avatar igorwwwwwwwwwwwwwwwwwwww commented on June 18, 2024

Thanks for explaining. I've opened a ticket with gvt as well, so I hope they choose to address it on their side. :)

from zipkin-go-opentracing.

basvanbeek avatar basvanbeek commented on June 18, 2024

I'm going to close this as I don't see this as an error on my end. If GVT has a valid reason why to ignore this on the file checkout you can reopen and I will reassess.

from zipkin-go-opentracing.

igorwwwwwwwwwwwwwwwwwwww avatar igorwwwwwwwwwwwwwwwwwwww commented on June 18, 2024

Works for me, thanks! :)

For the record, I opened this issue with gvt: FiloSottile/gvt#85

from zipkin-go-opentracing.

tomwilkie avatar tomwilkie commented on June 18, 2024

The new dep tool is also doing this: golang/dep#298 no it doesn't, sorry.

from zipkin-go-opentracing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.