Comments (5)
As all the code under _thrift
is generated I specifically prefixed with _
so it would not be included in tests, coverage, linting, etc.
Seems GVT includes omitting behavior to extend to pulling in code too which is rather strange as one would expect the VC to not include items that should be ignored.
from zipkin-go-opentracing.
Thanks for explaining. I've opened a ticket with gvt as well, so I hope they choose to address it on their side. :)
from zipkin-go-opentracing.
I'm going to close this as I don't see this as an error on my end. If GVT has a valid reason why to ignore this on the file checkout you can reopen and I will reassess.
from zipkin-go-opentracing.
Works for me, thanks! :)
For the record, I opened this issue with gvt: FiloSottile/gvt#85
from zipkin-go-opentracing.
The new dep tool is also doing this: golang/dep#298 no it doesn't, sorry.
from zipkin-go-opentracing.
Related Issues (20)
- Move to `openzipkin-contrib` HOT 2
- Is x-b3-flags mandatory? HOT 4
- Use correct Thrift import path HOT 1
- Tags are serialized in arbitrary and varying order HOT 1
- loop in scribe collector infinitely spawns send() goroutines HOT 2
- Incorrect nil error return in MultiCollector aggregateErrors method HOT 1
- HTTPCollector. send goroutine only increase without decreasing HOT 2
- Span extraction fails for valid carriers and succeeds for invalid carriers HOT 1
- Allow custom TraceID to be set HOT 7
- Fix B3 extraction HOT 1
- when support zipkin v2 HOT 8
- Thrift HttpCollector overflow issues HOT 1
- zipkinContext.TraceID.ToHex undefined (type model.TraceID has no field or method ToHex) HOT 12
- failed to inject span: opentracing: Invalid Inject/Extract carrier HOT 7
- unexpected module path "github.com/openzipkin-contrib/zipkin-go-opentracing" HOT 2
- Inject always fails with 'opentracing: Invalid Inject/Extract carrier' when falling back to TextMapWriter HOT 1
- How to set sampling rate? HOT 1
- Observers cannot access native zipkin span instance HOT 2
- dependencies versions should be upgraded to address security vulnerabilities HOT 6
- how to get traceID from span or ctx ? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zipkin-go-opentracing.