IWatchableVariableListFeature may need access to experiment results about org.geppetto.core

[gidili]

@jrmartin @tarelli @adrianq what do you guys think? I am currently blocked by the above, the way things changed makes it so without the change I suggest (or equivalent) whatever I was doing in the dev branch is not working in datamanager. Any better ideas?

BTW I have the same identical problem on the IVisualTreeFeature interface on this implementation where visulization tree variables where being fished from the recording.

[jrmartin]

I spent some time looking at possibility of adding resutls to Aspect's model wrapper as before, to avoid any changes to interface. Best I thought would be to add ModelWrapper with results to Aspect node before calling the feature, this will have to happen somewhere in RuntimeExperiment.java class. Otherwise, interface change sounds good as well.

[adrianq]

@gidili I am not sure if I fully understand your problem. If you are dealing with recordings it is because the simulation is done and we can assume the experiment is finished, right? If so you shouldn't be calling populate simulation tree but the simulation tree should be populate here. I guess you don't have the aspect configurations with the watched variables for the recordings but what you have for sure is the experiment and maybe from there you can call a method like listWatchableVariables(AspectNode aspectNode, Experiment experiment). However I realise that you would still have the problem with the visualisation feature...

That said, I wouldn't move a comma without listening to @tarelli opinion ;)

[gidili]

@adrianq thanks - we had a chat with @tarelli and I was confused by the fact that we are calling populateSimulationTree in GeppettoManager.updateRuntimeTreesWithResults so I thought it was necessary, but the trees are actually populate already before that call so it would seem it is redundant (I tried commenting it out and everything works so I guess we should take it out). I just have to extend the "createVariables" stuff for the visualisation tree and it should be OK.

Also thanks @jrmartin for you suggestion.

[tarelli]

Obsolete post instance type refactoring