Make Coverage with Build Jobs > 1 Results in Duplicative Weave Unit Test Output about openweave-core

[gerickson]

% configure --enable-coverage --enable-coverage-reports --disable-docs --enable-debug --enable-optimization=no --enable-stdio-logging-timestamps --without-bluez --without-happy | & tee configure.output
% make -j2 coverage | & tee make-coverage.output
% grep TestAppKeys make-coverage.output
CXX TestAppKeys.o
CXX TestAppKeys.o
CXXLD TestAppKeys
CXXLD TestAppKeys
make TestASN1 TestAppKeys TestArgParser TestCASE TestCodeUtils TestCrypto TestDRBG TestDeviceDescriptor TestDNSResolution TestECDH TestECDSA TestECMath TestEventLogging TestFabricStateDelegate TestInetAddress TestInetBuffer TestInetEndPoint TestInetTimer TestKeyExport TestKeyIds TestMsgEnc TestNetworkInfo TestPASE TestPacketBuffer TestPasscodeEnc TestPersistedCounter TestPersistedStorage TestProfileStringSupport TestProvHash TestRetainedPacketBuffer TestSerialNumUtils TestSystemObject TestSystemTimer TestTAKE TestTLV TestTimeUtils TestTimeZone TestWeaveCert TestWeaveEncoding TestWeaveFabricState TestWeaveSignature infratest wsuptest TestErrorStr TestStatusReportStr TestThermostatStatus TestWoble TestPairingCodeUtils TestResourceIdentifier TestTDM TestTDM TestPathStore TestWdmUpdateEncoder TestWdmUpdateResponse TestWarm TestWeaveProvBundle test-weave-device-descriptor-encode.sh test-Verhoeff.sh TestWeaveTool.py
make[4]: 'TestAppKeys' is up to date.
PASS: TestAppKeys
make TestASN1 TestAppKeys TestArgParser TestCASE TestCodeUtils TestCrypto TestDRBG TestDeviceDescriptor TestDNSResolution TestECDH TestECDSA TestECMath TestEventLogging TestFabricStateDelegate TestInetAddress TestInetBuffer TestInetEndPoint TestInetTimer TestKeyExport TestKeyIds TestMsgEnc TestNetworkInfo TestPASE TestPacketBuffer TestPasscodeEnc TestPersistedCounter TestPersistedStorage TestProfileStringSupport TestProvHash TestRetainedPacketBuffer TestSerialNumUtils TestSystemObject TestSystemTimer TestTAKE TestTLV TestTimeUtils TestTimeZone TestWeaveCert TestWeaveEncoding TestWeaveFabricState TestWeaveSignature infratest wsuptest TestErrorStr TestStatusReportStr TestThermostatStatus TestWoble TestPairingCodeUtils TestResourceIdentifier TestTDM TestTDM TestPathStore TestWdmUpdateEncoder TestWdmUpdateResponse TestWarm TestWeaveProvBundle test-weave-device-descriptor-encode.sh test-Verhoeff.sh TestWeaveTool.py
make[3]: 'TestAppKeys' is up to date.
PASS: TestAppKeys

Note that TestAppKeys.o is built twice and TestAppKeys is run twice. However, one is run at sub-make level four (4) and the other at three (3).

[gerickson]

The problem seems to be focused on the directory src/test-apps and can be trivially simplified and reproduced with this invocation:

% make -C src/test-apps -j2 coverage TESTS=TestAppKeys

[gerickson]

If I run any of:

% make -j2 -C third_party/{nlassert,nlfaultinjection,nlio}/repo/tests coverage

I only see one test pass indicating that the issue is specific to the Weave unit and functional tests.

[gerickson]

If I simplify src/test-apps/Makefile.am down to the bare minimum needed to support TestAppKeys as a test program, the duplication goes away.

[gerickson]

The core problem seems to be the following:

SUBDIRS                                               = \
    wrapper-tests/jni                                   \
    $(NULL)

In fact, just defining:

SUBDIRS = 

creates the problem.

[gerickson]

This was resolved by having the local coverage target in src/test-apps depend on a local, rather than recursive, check target. Having both 'coverage' as the target make command goal and a local dependency on 'check' was causing the double sub-directory recursion and unit test execution with parallel build jobs.