Coder Social home page Coder Social logo

Comments (6)

ChanceNCounter avatar ChanceNCounter commented on August 22, 2024

This is present in 0.0.6 #266 so it's in the wild

from ovos-core.

AIIX avatar AIIX commented on August 22, 2024

This is present in 0.0.6 #266 so it's in the wild

skills-essential is not an egg manjaro packages, because its got its own set of skills, the skills were not part of the requirements.txt that is the very basic to get any platform running before 0.0.7, we only install requirements.txt

from ovos-core.

ChanceNCounter avatar ChanceNCounter commented on August 22, 2024

I think this might speak to a broader need to clarify all those dep models, because, now that I've looked at the cleanup pass that introduced the offending dep to requirements.txt, it looks like Jarbas was trying to make them a little easier to read and his clipboard betrayed him. The whole set came over! I'm guessing something else was meant to go in that spot.

from ovos-core.

AIIX avatar AIIX commented on August 22, 2024

Whatever it is, I would suggest and hope not doing an other Mycroft forcing their skills on installations, then causing platforms and distributions and anyone wanting to make any product out of ovos being forced to add ugly workarounds and hacks at various levels to deal with this issue.

from ovos-core.

AIIX avatar AIIX commented on August 22, 2024

Marking #277 this as a potential fix for this issue, where platforms packaging OVOS can choose to only install the platform-requirements.txt and not include base skills

from ovos-core.

JarbasAl avatar JarbasAl commented on August 22, 2024

packaging is roadmapped for 0.0.8, the metapackages automations will make this clearer, this immediate issue is fixed by #278

0.0.7 only has roadmapped to finish the defaults skills list introduced in 0.0.6, we probably should split this into several recommended lists, all these optional and not part of all except for essential

  • essential_skills -> needed for core to work, "unknown", "stop" etc
  • recommended_skills -> what we ship in our images, so we all use the same list
  • media_skills -> recommended list of base skills for media center, some music radio etc skills

PRs welcome to get the above going, many skills still need automations and publishing in pypi

some info for other people, adapted from chat discussion:


an explanation of requirements is warranted:

  • minimal -> this is shared between all services and always needed, its the ovos-core lib
  • bus -> extra deps for running bus service
  • skills -> extra deps for running skill service
  • X -> extra deps for running X service
  • skills_essential -> list of essential ovos skills
  • requirements.txt -> all in setup.py, when you want the full voice assistant

not having skills in all was raised a few times in chat by new users, so they were added there, also this is what manual git installs will usually pull

a distro should never use requirements.txt, distros should use minimal + the relevant individual services, we can even add new optional requirements with default skills for distros we want to officially support (eg, bigscreen). the WIP metapackages will make this easier on the distros side when packaging

from ovos-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.