Coder Social home page Coder Social logo

Comments (12)

anzr299 avatar anzr299 commented on July 26, 2024 1

I've created a PR #315

from openvino.genai.

anzr299 avatar anzr299 commented on July 26, 2024 1

@ilya-lavrenov I've created a PR at #353

from openvino.genai.

anzr299 avatar anzr299 commented on July 26, 2024

.take

from openvino.genai.

p-wysocki avatar p-wysocki commented on July 26, 2024

Hello @anzr299, the ticket will be manually assigned to you shortly - the take feature hasn't been introduced to GenAI repo yet, but it will be today. :)

Thanks for taking a look at the issue!

from openvino.genai.

p-wysocki avatar p-wysocki commented on July 26, 2024

Hello @anzr299, are you still working on this? Is there anything we could help you with?

from openvino.genai.

anzr299 avatar anzr299 commented on July 26, 2024

Hi, I am still working on it, was busy the past few days.

from openvino.genai.

anzr299 avatar anzr299 commented on July 26, 2024

I have a small question, in beam_search_casual_lm.cpp, the following lines check for an empty token and not the hardcoded EOS token. Should I change this as well to check for the EOS token?
if (next_tokens.empty()) { break; }
(lines 60-62)

from openvino.genai.

p-wysocki avatar p-wysocki commented on July 26, 2024

cc @pavel-esir

from openvino.genai.

pavel-esir avatar pavel-esir commented on July 26, 2024

I have a small question, in beam_search_casual_lm.cpp, the following lines check for an empty token and not the hardcoded EOS token. Should I change this as well to check for the EOS token? if (next_tokens.empty()) { break; } (lines 60-62)

good question! No need to update beam_searcher, just initialize it with eos token you got from IR in the sample. Please look my comments in you PR.

from openvino.genai.

anzr299 avatar anzr299 commented on July 26, 2024

@ilya-lavrenov The issue asked to add a functionality to read EOS tokens only for beam_search_causal_lm and greedy_causal_lm but not for speculative_decoding_lm. I followed the requirement in my work but I thought it could be better if I added the functionality to speculative_decoding_lm too. Is that alright?

from openvino.genai.

ilya-lavrenov avatar ilya-lavrenov commented on July 26, 2024

I followed the requirement in my work but I thought it could be better if I added the functionality to speculative_decoding_lm too. Is that alright?

Yes, let's handle this sample as well.
The initial requirements were added before the speculative_decoding_lm sample is implemented.

from openvino.genai.

anzr299 avatar anzr299 commented on July 26, 2024

I followed the requirement in my work but I thought it could be better if I added the functionality to speculative_decoding_lm too. Is that alright?

Yes, let's handle this sample as well. The initial requirements were added before the speculative_decoding_lm sample is implemented.

Sure, I will create a new PR

from openvino.genai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.