[Good First Issue]: causal_lm/cpp must read EOS token value from rt_info of openvino_tokenizer.xml about openvino.genai

[anzr299]

I've created a PR #315

[anzr299]

@ilya-lavrenov I've created a PR at #353

[anzr299]

.take

[p-wysocki]

Hello @anzr299, the ticket will be manually assigned to you shortly - the take feature hasn't been introduced to GenAI repo yet, but it will be today. :)

Thanks for taking a look at the issue!

[p-wysocki]

Hello @anzr299, are you still working on this? Is there anything we could help you with?

[anzr299]

Hi, I am still working on it, was busy the past few days.

[anzr299]

I have a small question, in beam_search_casual_lm.cpp, the following lines check for an empty token and not the hardcoded EOS token. Should I change this as well to check for the EOS token?
if (next_tokens.empty()) { break; }
(lines 60-62)

[p-wysocki]

cc @pavel-esir

[pavel-esir]

I have a small question, in beam_search_casual_lm.cpp, the following lines check for an empty token and not the hardcoded EOS token. Should I change this as well to check for the EOS token? if (next_tokens.empty()) { break; } (lines 60-62)

good question! No need to update beam_searcher, just initialize it with eos token you got from IR in the sample. Please look my comments in you PR.

[anzr299]

@ilya-lavrenov The issue asked to add a functionality to read EOS tokens only for beam_search_causal_lm and greedy_causal_lm but not for speculative_decoding_lm. I followed the requirement in my work but I thought it could be better if I added the functionality to speculative_decoding_lm too. Is that alright?

[ilya-lavrenov]

I followed the requirement in my work but I thought it could be better if I added the functionality to speculative_decoding_lm too. Is that alright?

Yes, let's handle this sample as well.
The initial requirements were added before the speculative_decoding_lm sample is implemented.

[anzr299]

I followed the requirement in my work but I thought it could be better if I added the functionality to speculative_decoding_lm too. Is that alright?

Yes, let's handle this sample as well. The initial requirements were added before the speculative_decoding_lm sample is implemented.

Sure, I will create a new PR