Comments (12)
I've created a PR #315
from openvino.genai.
@ilya-lavrenov I've created a PR at #353
from openvino.genai.
.take
from openvino.genai.
Hello @anzr299, the ticket will be manually assigned to you shortly - the take feature hasn't been introduced to GenAI repo yet, but it will be today. :)
Thanks for taking a look at the issue!
from openvino.genai.
Hello @anzr299, are you still working on this? Is there anything we could help you with?
from openvino.genai.
Hi, I am still working on it, was busy the past few days.
from openvino.genai.
I have a small question, in beam_search_casual_lm.cpp
, the following lines check for an empty token and not the hardcoded EOS token. Should I change this as well to check for the EOS token?
if (next_tokens.empty()) { break; }
(lines 60-62)
from openvino.genai.
cc @pavel-esir
from openvino.genai.
I have a small question, in
beam_search_casual_lm.cpp
, the following lines check for an empty token and not the hardcoded EOS token. Should I change this as well to check for the EOS token?if (next_tokens.empty()) { break; }
(lines 60-62)
good question! No need to update beam_searcher, just initialize it with eos token you got from IR in the sample. Please look my comments in you PR.
from openvino.genai.
@ilya-lavrenov The issue asked to add a functionality to read EOS tokens only for beam_search_causal_lm and greedy_causal_lm but not for speculative_decoding_lm. I followed the requirement in my work but I thought it could be better if I added the functionality to speculative_decoding_lm too. Is that alright?
from openvino.genai.
I followed the requirement in my work but I thought it could be better if I added the functionality to speculative_decoding_lm too. Is that alright?
Yes, let's handle this sample as well.
The initial requirements were added before the speculative_decoding_lm sample is implemented.
from openvino.genai.
I followed the requirement in my work but I thought it could be better if I added the functionality to speculative_decoding_lm too. Is that alright?
Yes, let's handle this sample as well. The initial requirements were added before the speculative_decoding_lm sample is implemented.
Sure, I will create a new PR
from openvino.genai.
Related Issues (20)
- [Good First Issue]: Verify Phi-1_5 with GenAI text_generation HOT 9
- Add profiling option to C++ sample for greedy_causal_lm HOT 3
- MPT-30B met convert issue
- Falcon-40B convert successfully but output_dir has not been created HOT 9
- Convert failed using Salesforce/codegen25-7b-multi HOT 2
- Convert failed of baichuan-inc/Baichuan2-13B-Chat HOT 1
- [Improvement] Wrong output size of google/flan-t5-xl HOT 7
- Convert.py breaks for microsoft/trocr-base-printed HOT 3
- Migrate to optimum-cli from llm_bench usage
- Requesting help to understand how TTFT is calculated. Is there any documentation? HOT 3
- MPT-30B met benchmarking issue HOT 1
- ChatGLM3 output token size is not generated as expected HOT 6
- stable diffusion 1.5 generates noise image with "--num"
- Causal LM text generation example errors out HOT 5
- [Good First Issue]: Project won't run because it can't load openvino_tokenizers.dll - even though it exists! HOT 5
- FullyConnected nodes use slow reference kernel on ARM HOT 18
- some regression for benchmark on stable diffusion v1.5 HOT 5
- the quality of generated image is low by benchmark on stable diffusion v1.5 HOT 7
- chatglm3 fails with jsonl input HOT 9
- llama3 perf is low HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openvino.genai.