Coder Social home page Coder Social logo

Comments (4)

kevinkreiser avatar kevinkreiser commented on September 4, 2024

just a couple FYIs

sending to the datastore will already be disabled by not defining the datstore_url env var. we do lack any way of doing this on a per request basis though, so its important to note that this is to be added to the request.

the code already does report everything it reports to the datastore verbatim. it needs to do this so that the kafka worker can trim the batch windows accordingly. so we dont need to add this so much as keep doing it.

from reporter.

dnesbitt61 avatar dnesbitt61 commented on September 4, 2024

Design discussion: Datastore does not need all fields in the data (shape indexes) and needs to add next segment logic (merging across internal segments, etc.). Trimming logic perhaps only needs to know the shape index (index into the reported trace) that can be trimmed - might be best to put that logic in the Python code. Where to decide whether to report on local segments (and local next segments)? Could be cone with logic in the Reporter (based on config) or could be done at Datastore (or both). Doing in Reporter could keep sensitive(privacy) concerns of residential areas within the TNC and would reduce amount of data sent to the Datastore. Doing at Datastore would allow easier future updates to handle local roads reporting (since centralized at the Datastore rather the distributed across different TNCs).

from reporter.

dnesbitt61 avatar dnesbitt61 commented on September 4, 2024

Debug flag is not needed since other Reporter stages will now aggregate and send to Datastore. One can simply call the Python report method to test individual traces and receive results about segment matches, next segment transitions, queue_lengths, etc.

from reporter.

drewda avatar drewda commented on September 4, 2024

closed by #71

from reporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.