Coder Social home page Coder Social logo

Comments (10)

rnburn avatar rnburn commented on August 25, 2024 1

@kop I just put in some fixes to make the Jaeger module work. I did some testing and I believe writing something like this in your nginx.conf will give you what you want:

 http {
    opentracing on;
    jaeger_service_name test-nginx;
    jaeger_sampler_type probabilistic;
    jaeger_sampler_param 0.01; # Sample 10% of requests.

But note that there's a bug in Jaeger if you try to use a sample param of 100% (jaegertracing/jaeger-client-cpp#6).

@isaachier -- Could you document the different options available for jaeger_sampler_type? I had to grep through Jaeger's code to find this.

from nginx-opentracing.

rnburn avatar rnburn commented on August 25, 2024

Sampling is usually done as a feature of the tracing libraries. I'm ok adding it to zipkin-cpp-opentracing and exposing it as an option.

I believe the Jaeger implementation already has an option for this, though I don't know if it's quite ready for use yet.

from nginx-opentracing.

kop avatar kop commented on August 25, 2024

@rnburn thank you for the answer.

Jaeger is the tracer I'm using and I'm asking because I don't know any way how to configure this in Jaeger agent. This option is available in all Jaeger client libraries and I was expecting it to be here too.

It would be great to have such option.

from nginx-opentracing.

rnburn avatar rnburn commented on August 25, 2024

Adding @isaachier, @yurishkuro to see if they can answer.

I think the library is still under development so it may not have all the options yet.

from nginx-opentracing.

isaachier avatar isaachier commented on August 25, 2024

Yes there is a way and I have a fork of this project in development now. Builds on docker but haven't tested it yet.

from nginx-opentracing.

yurishkuro avatar yurishkuro commented on August 25, 2024

while Jaeger clients provide a way to configure sampling priority, the default mode we recommend is letting the clients pull the sampling strategy from Jaeger backend (cf. jaegertracing/jaeger#365).

from nginx-opentracing.

rnburn avatar rnburn commented on August 25, 2024

@kop I think this is the option to set the agent host and port if that's what you're looking for.

from nginx-opentracing.

kop avatar kop commented on August 25, 2024

while Jaeger clients provide a way to configure sampling priority, the default mode we recommend is letting the clients pull the sampling strategy from Jaeger backend (cf. jaegertracing/jaeger#365).

This sounds great and should be much easier to work with, however this is something from the future. We still need a way to set sampling rate for current usage.

@kop I think this is the option to set the agent host and port if that's what you're looking for.

Thank you, this is not exactly what was my question about :)

from nginx-opentracing.

isaachier avatar isaachier commented on August 25, 2024

Sure thing. Not sure when but soon enough.

from nginx-opentracing.

rnburn avatar rnburn commented on August 25, 2024

Closing. If you also want sampling for zipkin, please put in an issue to https://github.com/rnburn/zipkin-cpp-opentracing.

from nginx-opentracing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.