Comments (10)
@kop I just put in some fixes to make the Jaeger module work. I did some testing and I believe writing something like this in your nginx.conf will give you what you want:
http {
opentracing on;
jaeger_service_name test-nginx;
jaeger_sampler_type probabilistic;
jaeger_sampler_param 0.01; # Sample 10% of requests.
But note that there's a bug in Jaeger if you try to use a sample param of 100% (jaegertracing/jaeger-client-cpp#6).
@isaachier -- Could you document the different options available for jaeger_sampler_type? I had to grep through Jaeger's code to find this.
from nginx-opentracing.
Sampling is usually done as a feature of the tracing libraries. I'm ok adding it to zipkin-cpp-opentracing and exposing it as an option.
I believe the Jaeger implementation already has an option for this, though I don't know if it's quite ready for use yet.
from nginx-opentracing.
@rnburn thank you for the answer.
Jaeger is the tracer I'm using and I'm asking because I don't know any way how to configure this in Jaeger agent. This option is available in all Jaeger client libraries and I was expecting it to be here too.
It would be great to have such option.
from nginx-opentracing.
Adding @isaachier, @yurishkuro to see if they can answer.
I think the library is still under development so it may not have all the options yet.
from nginx-opentracing.
Yes there is a way and I have a fork of this project in development now. Builds on docker but haven't tested it yet.
from nginx-opentracing.
while Jaeger clients provide a way to configure sampling priority, the default mode we recommend is letting the clients pull the sampling strategy from Jaeger backend (cf. jaegertracing/jaeger#365).
from nginx-opentracing.
@kop I think this is the option to set the agent host and port if that's what you're looking for.
from nginx-opentracing.
while Jaeger clients provide a way to configure sampling priority, the default mode we recommend is letting the clients pull the sampling strategy from Jaeger backend (cf. jaegertracing/jaeger#365).
This sounds great and should be much easier to work with, however this is something from the future. We still need a way to set sampling rate for current usage.
@kop I think this is the option to set the agent host and port if that's what you're looking for.
Thank you, this is not exactly what was my question about :)
from nginx-opentracing.
Sure thing. Not sure when but soon enough.
from nginx-opentracing.
Closing. If you also want sampling for zipkin, please put in an issue to https://github.com/rnburn/zipkin-cpp-opentracing.
from nginx-opentracing.
Related Issues (20)
- Query parameters in "http.url" tag HOT 3
- Support OpenTelemetry C++ HOT 3
- Support Datadog metrics over unix socket
- seg fault errors during span extraction HOT 1
- start nginx failed,`libopentracing.so.1 can not open` HOT 2
- Traces are not delivered after a few days of runtime HOT 1
- Zipkin Support in the OpenResty Docker Image HOT 1
- Error when building on centos7 No such file or directory dynamic_load.h propagation.h HOT 1
- Support Arm for Openresty HOT 4
- Support for Nginx 1.24.0 HOT 1
- How can I pass trace_id from nginx to python-flask app server and associate these two trace into one while I query traces in Jaeger UI? HOT 3
- Opentracing directive behavior in http vs location block
- Trace binding (query tree) HOT 3
- Assert are missing on v0.33.0 release HOT 2
- `-ot16-` files/artifacts has been deleted from releases HOT 3
- does not capture traces when clients see "upstream prematurely closed connection" HOT 4
- Opentracing module not work in alpine nginx HOT 3
- Docker images are not updated automatically anymore HOT 4
- Make Openresty image public on GitHub HOT 1
- libjaegertracing_plugin.so missing debian libyaml-cpp dependency
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nginx-opentracing.