Comments (16)
At the moment we don't have any specific plans for redis instrumentation. If anybody is interested please comment or 👍 on this issue.
from java-spring-cloud.
@ddcprg I am not aware of anybody. It would be great if you could have a look 👍
from java-spring-cloud.
@qw2283345 hi,
what API are you using to access Redis storage? RedisTemplate or something else?
from java-spring-cloud.
@pavolloffay thanks for replay, do you have any plan to make OpenTracing to support redis?
from java-spring-cloud.
I am wondering if this is feasible without instrumenting a third party client and/or the Redis code itself. The only way that I can see of getting around that is potentially the pub/sub feature, but not sure how much sense that makes. If that isn't feasible, would it make sense to wrap the Redis networking code using opentracing-c? Just wondering how this third-party instrumentation usually works. @pavolloffay @rnburn @yurishkuro please let me know your thoughts here.
from java-spring-cloud.
@isaachier I think this issue is mostly about instrumenting client side. Afaik Redis has a fairly open and well documented wire protocol, so most clients can be written natively in the chosen language without relying on some low-level libraries. I think your suggestion of opentracing-c applies more on the server side. I don't have any insight how feasible it is (probably possible).
from java-spring-cloud.
I mean is it reasonable to instrument the server-side or would that mean maintaining a fork which may not be part of the OpenTracing mission?
from java-spring-cloud.
I think the only viable approach for instrumenting 3rd party products server-side is if they either support pluggable instrumentation (like Cassandra), or they are willing to integrate OpenTracing API directly (as couchbase or grafana). Maintaining a fork is certainly not a viable long term strategy.
from java-spring-cloud.
OK got it thanks.
from java-spring-cloud.
This issue is related to the client side only. I haven't looked into this very closely but it seems we will have to instrument RedisTemplate
and maybe also message receiver.
from java-spring-cloud.
There is also https://github.com/opentracing-contrib/java-redis-client which could be perhaps used as the underlying instrumentation.
from java-spring-cloud.
Right I sort of hijacked this issue to refer to the server side. Having so many client side instrumentations seems more difficult than maintaining one redis server instrumentation.
from java-spring-cloud.
Is anyone working on this already? I wouldn't mind taking a look since I need this feature
from java-spring-cloud.
I've managed to spend some time on this issue this evening. I'll try to push a PR tomorrow.
from java-spring-cloud.
Done in #182
from java-spring-cloud.
thanks @pavolloffay
from java-spring-cloud.
Related Issues (20)
- Application Context fails to start due to dependency on org.springframework:spring-web
- spring-ws
- Application won't start with opentracing.spring.cloud.reactor.enabled=true HOT 1
- NoClassDefFoundError: org/springframework/cloud/openfeign/ribbon/LoadBalancerFeignClient when using spring-cloud-dependencies:2020.0.0 HOT 15
- DefaultAsyncAutoConfiguration override a implicit AsyncTaskExecutor
- Could not report to Jaeger when using spring cloud apigw
- Trace Span logs not appended to the loggers HOT 2
- What's the plan for supporting Spring Cloud 2020 HOT 1
- Spring boot messaging Failed to serialize object caused by jaeger HOT 1
- Does this support Honeycomb open tracing?
- Release of version 0.6.0 to maven central HOT 5
- TraceRequestHttpHeadersFilter Overrides headers
- not support ConcurrentTaskScheduler?
- Using OT side-by-side with NewRelic
- Update jaeger-client dependency due to CVE-2020-13949 HOT 4
- java.lang.NoSuchMethodError: 'io.opentracing.Scope io.opentracing.Tracer$SpanBuilder.startActive(boolean) HOT 1
- ignoreStatements not working for opentracing-spring-cloud-mongo-starter
- `opentracing-spring-cloud-redis-starter` RedisClusterConnection wrapped in TracingRedisConnection
- Dependency to opentracing-spring-jaeger-cloud-starter removes "http_server_requests_seconds_count" metric since SpringBoot 2.7.0
- `uber-trace-id` from incoming request overwrites client span in spring cloud gateway tracing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from java-spring-cloud.