Coder Social home page Coder Social logo

Comments (4)

pavolloffay avatar pavolloffay commented on August 25, 2024

As you mentioned the preferred way in spring is to inject via spring context.

All good instrumentations should support passing a tracer instance as object and not relay only on GlobalTracer.

from java-spring-cloud.

pavolloffay avatar pavolloffay commented on August 25, 2024

I would like to keep the lib as simple as possible if there will be a request to bind the tracer to GlobalTracer then we could re-review and see what is necessary to make it work properly.

from java-spring-cloud.

objectiser avatar objectiser commented on August 25, 2024

Ok sounds reasonable - and also simplifies things for now.

So I don't think the current TracerAutoConfiguration needs to change to reference the GlobalTracer - as essentially with the spring ecosystem we are not going to use the GlobalTracer. So this auto-config is providing the fallback to obtain a tracer if no other bean has been provided.

It might be a good idea for this auto-config to be moved into the java-spring-cloud repo, independent of spring-web, as it is applicable to all spring instrumentations.

from java-spring-cloud.

pavolloffay avatar pavolloffay commented on August 25, 2024

fixed via opentracing-contrib/java-spring-web#30

from java-spring-cloud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.