Comments (4)
As you mentioned the preferred way in spring is to inject via spring context.
All good instrumentations should support passing a tracer instance as object and not relay only on GlobalTracer
.
from java-spring-cloud.
I would like to keep the lib as simple as possible if there will be a request to bind the tracer to GlobalTracer
then we could re-review and see what is necessary to make it work properly.
from java-spring-cloud.
Ok sounds reasonable - and also simplifies things for now.
So I don't think the current TracerAutoConfiguration
needs to change to reference the GlobalTracer
- as essentially with the spring ecosystem we are not going to use the GlobalTracer
. So this auto-config is providing the fallback to obtain a tracer if no other bean has been provided.
It might be a good idea for this auto-config to be moved into the java-spring-cloud repo, independent of spring-web, as it is applicable to all spring instrumentations.
from java-spring-cloud.
fixed via opentracing-contrib/java-spring-web#30
from java-spring-cloud.
Related Issues (20)
- Application Context fails to start due to dependency on org.springframework:spring-web
- spring-ws
- Application won't start with opentracing.spring.cloud.reactor.enabled=true HOT 1
- NoClassDefFoundError: org/springframework/cloud/openfeign/ribbon/LoadBalancerFeignClient when using spring-cloud-dependencies:2020.0.0 HOT 15
- DefaultAsyncAutoConfiguration override a implicit AsyncTaskExecutor
- Could not report to Jaeger when using spring cloud apigw
- Trace Span logs not appended to the loggers HOT 2
- What's the plan for supporting Spring Cloud 2020 HOT 1
- Spring boot messaging Failed to serialize object caused by jaeger HOT 1
- Does this support Honeycomb open tracing?
- Release of version 0.6.0 to maven central HOT 5
- TraceRequestHttpHeadersFilter Overrides headers
- not support ConcurrentTaskScheduler?
- Using OT side-by-side with NewRelic
- Update jaeger-client dependency due to CVE-2020-13949 HOT 4
- java.lang.NoSuchMethodError: 'io.opentracing.Scope io.opentracing.Tracer$SpanBuilder.startActive(boolean) HOT 1
- ignoreStatements not working for opentracing-spring-cloud-mongo-starter
- `opentracing-spring-cloud-redis-starter` RedisClusterConnection wrapped in TracingRedisConnection
- Dependency to opentracing-spring-jaeger-cloud-starter removes "http_server_requests_seconds_count" metric since SpringBoot 2.7.0
- `uber-trace-id` from incoming request overwrites client span in spring cloud gateway tracing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from java-spring-cloud.