IE 11 ignores dialogWidth-Height about opentouryo

[daisukenishino]

Additional information

I got the following information from the project.

If you change from the frameset to iframe, then dialog is resizable.

This information was confirmed that it will work properly in the following modifications.

• DialogFrame.htm
  https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Samples/WebApp_sample/ProjectX_sample/Aspx/Framework/DialogFrame.htm

Before correction

<frameset cols="100%" style="margin:0px; padding:0px; border-style:none; background-color:#cccccc;">
    <frame id="frame1" src="./DialogLoader.htm" style="background-color:#cccccc; " />
</frameset>

After correction

<iframe id="frame1" src="./DialogLoader.htm" frameborder="0" style="overflow:hidden;overflow-x:hidden;overflow-y:hidden;height:100%;width:100%;position:absolute;top:0px;left:0px;right:0px;bottom:0px;background-color:#cccccc;" height="100%" width="100%">・・・</iframe>

[daisukenishino]

Changed the Status.

Change the Label from [wontfix] to [enhance], and reopened.

Modification contents

This will changed to iframe from frameset in the DialogFrame.htm.

• This correspondence is required not only IE9.
• This correspondence have been required because this was continued until the IE11.

[daisukenishino]

Support browsers

Since this feature is using a showModalDialog,
this feature does not support modern browser, such as the following.

• Chrome
• Firefox
• Safari
• Opera

Alternative implementation to support of the business modal dialog display function for modern browser is currently under consideration. But, at the moment, I think that there is a high possibility that the support of this feature abort in the future.

[daisukenishino]

How to test

Press the following buttons to display the business modal dialog.
https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Samples/WebApp_sample/ProjectX_sample/Aspx/testFxLayerP/normal/testScreen1.aspx#L60

[kishoreandukuri]

@daisukenishino

We have fixed and tested.
Please confirm below

[daisukenishino]

@kishoreandukuri

#74 (comment)

Good.

Please confirm that the specified size is reflected.

• app.config - appSettings - FxDefaultBusinessDialogStyle
  https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Samples/WebApp_sample/ProjectX_sample/app.config#L34

[kishoreandukuri]

@daisukenishino

Please confirm that the specified size is reflected.

We have set specified size using appsetting. But the size is not reflecting.

[daisukenishino]

@kishoreandukuri

But the size is not reflecting.

Please investigate the dialogWidth and dialogHeight problems of window.showModalDialog() method in IE11 on internet. I found the following information. Please try to delete the "xp".
https://productforums.google.com/forum/#!topic/chrome-ja/jwHRnMJ6oJ8

[kishoreandukuri]

@daisukenishino

Please try to delete the "xp".

I removed "px" in appsetting and checked. Still the specified size is not coming.

<add key="FxDefaultBusinessDialogStyle" value="dialogWidth:100;dialogHeight:100;status:no;" />

I'm doing investigation on this.

[daisukenishino]

@kishoreandukuri

#74 (comment)

There is a possibility that can be supported by correspond as following.

• Welcome To The Porch Garden:
  IE10以降、dialogWidthとdialogHeightの同時指定で画面が真っ白に。。
  http://porchgarden.blogspot.jp/2013/11/ie10dialogwidthdialogheight.html

If this is true,

pass the size and existing url information to the second argument of showModalDialog by array,

• https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Samples/WebApp_sample/ProjectX_sample/Framework/Js/common.js#L735

And, specify the size in the dialog side.

• https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Samples/WebApp_sample/ProjectX_sample/Aspx/Framework/DialogFrame.htm

<script type="text/javascript"><!--
  var args = window.dialogArguments;
  var args1 = args[0];
  var args2 = args[1];
  var items = args2.split(";");
  items.forEach(function(item){
    if(item.indexOf("dialogWidth") == 0)
    {
      window.dialogWidth = item.split(":")[1];
    }
    if(item.indexOf("dialogHeight") == 0)
    {
      window.dialogHeight = item.split(":")[1];
    }
  });
//--></script>

[daisukenishino]

@SandeepNayak077

This change of VB version was also necessary.

• https://github.com/OpenTouryoProject/OpenTouryo/tree/develop/root/programs/C%23/Samples/WebApp_sample/ProjectX_sample/Aspx/Framework/DialogFrame.htm

▼ ▼ ▼

• https://github.com/OpenTouryoProject/OpenTouryo/tree/develop/root/programs/VB/Samples/WebApp_sample/ProjectX_sample/Aspx/Framework/DialogFrame.htm

[SandeepNayak077]

@daisukenishino

Ok, Thank you for the informaion.
We will do this changes and create new pull request.

[daisukenishino]

@SandeepNayak077

#74 (comment)

Thank you for your response.

But, We have detected one additional failure of CloseModalScreen_NoPostBack method by using the IFRAME.

• The window.returnValue of window.ShowModalDialog is no longer returned by using the IFRAME.
  window.returnValue become "undefined" in this situation.
  https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Samples/WebApp_sample/ProjectX_sample/Framework/Js/common.js#L866
• So, it is executing the postback in the parent screen by enter the following coverage despite "_NoPostBack".
  https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Samples/WebApp_sample/ProjectX_sample/Framework/Js/common.js#L772

[SandeepNayak077]

@daisukenishino

#74 (comment)

Ok, we will look in to this issue and report you.

[daisukenishino]

@SandeepNayak077

I'll investigate that we can cope with to return the "windows.returnValue" by using the cookie.

Ok, we will look in to this issue and report you.

Please to report if there is excellent proposal than the above.
Note : This change must be in time for release of the "01-72" version.

[daisukenishino]

@SandeepNayak077

I fixed it.
https://github.com/SymphonyTeleca/OpenTouryo/pull/105

Performe "nishino_work" branch for test and please check that there is no problem.

[SandeepNayak077]

@daisukenishino

#74 (comment)

Is it.!
Ok we will perform the testing.

[daisukenishino]

@SandeepNayak077

You can performe this test using testScreen1.aspx screen and each buttons.

Open

• ibnImageButton4
  ShowModalScreen method

Close

• btnButton22
  CloseModalScreen method
• lbnLinkButton22
  CloseModalScreen_NoPostBack method
• ibnImageButton22
  CloseModalScreen_WithAllParent method

[SandeepNayak077]

@daisukenishino

We have followed the test senario written in the above comment.
Testing was successful.

The modified code is working properly.
The ShowModalScreen method returning "1", "2" and "3" for the btnButton22, lbnLinkButton22 and ibnImageButton22 respectively.

Please merge the code to nishino branch.
So that we can merge it to root_VS2010 and higher.