We are currently merging. about opentouryo

[daisukenishino]

No.1

Issue description

XML comment of CustomMarshaler.PrimitivetypeFromString method has not been filled.
https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Frameworks/Infrastructure/Public/Util/CustomMarshaler.cs#L295

It is not possible to use methods for the description of the parameters is not sufficient.

Correspondence

Status

Completed.
3e29cba

[daisukenishino]

No.2

Issue description

XML comment of DTTable.SavejqGridJson method has not been filled.
https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Frameworks/Infrastructure/Public/Dto/DTTable.cs#L409

It is not possible to use methods for the description of the parameters is not sufficient.

Correspondence

Status

Completed.
3e29cba

[daisukenishino]

No.3

Issue description

Fixes for the following point is leaking.

• CmnDao
  • https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Frameworks/Infrastructure/Business/Dao/CmnDao.cs#L435
  • https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/VB/Frameworks/Infrastructure/Business/Dao/CmnDao.vb#L405
• DaoTemplate
  • https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/files/tools/DGenTemplates/DaoTemplate.cs#L88
  • https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/files/tools/DGenTemplates/DaoTemplate.vb#L86

Correspondence

Please refer to the following.

• #57 (comment)

(((DamSqlSvr)this.GetDam()).DamIDbCommand).CommandTimeout = this._commandTimeout;

↓ ↓ ↓

(((IDbCommand)this.GetDam()).DamSqlCommand).CommandTimeout = this._commandTimeout;

or

this.GetDam().DamSqlCommand.CommandTimeout = this._commandTimeout;

Status

Completed.
fcf0652

[daisukenishino]

No.4

Issue description

• IDE has been changed to VWD(Web Developer Express) from devenv(Professional).
  https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Samples/WebApp_sample/ProjectX_sample/ProjectX_sample.sln#L3
• Targetframework of ASP.NET has been changed to .NET v4.0 from .NET v3.5.
  https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Samples/WebApp_sample/ProjectX_sample/ProjectX_sample.sln#L6

However, the requested processing of jQGrid + JSON.NET seems to be the need .NET v4.0.

There was a contradiction in my request.

Correspondence

• The OpenTouryoProject/OpenTouryo to remain v3.5 ( revert changes from v4.0 ).
• The OpenTouryoProject/OpenTouryoTemplates apply changes from v4.0.

Status

Completed.

• 36bd9bd
• OpenTouryoProject/OpenTouryoTemplates@a09a21f
• OpenTouryoProject/OpenTouryoTemplates@3414534

[daisukenishino]

No.5

Commit unnecessary files.
(or, it have forgotten to delete from git repository.)

Issue description

Delete from git repository.

• \root\files\resource\Log\SQLTRACE.log
• \root\programs\C#\Frameworks\Infrastructure\Framework\AsyncProcessingService

Correspondence

It has been deleted.

Status

Completed.

[daisukenishino]

No.6

There is a possibility of bugs.

Issue description

DTTables

To the next line in the following lines
https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Frameworks/Infrastructure/Public/Dto/DTTables.cs#L481

Do not need the following Step ?

row[colIndex] = primitiveData;

Status

Completed.

• cd4ad19
• OpenTouryoProject/OpenTouryoTemplates@e10fd59

[daisukenishino]

@supragyan

Please support by quickly verification.
In addition, tests should be carried out enough.

The contents of the verification and test are carried out as follows.

• Create a Datatable(1).
• Save as text using the DTTables.save method.
• Restored as Datatable(2) using DTTables.Load method from the text.
• Please confirm that the save and load processing is appropriate
  by compare the contents of Datatable(1) and Datatable(2).

[daisukenishino]

No.7

There is a possibility of issue.

Issue description

DTTables

(1)

Commented out has been left for testing.
https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Frameworks/Infrastructure/Public/Dto/DTTables.cs#L58

//[System.Diagnostics.DebuggerStepThrough]

(2)

Save and Load method of DTTables in the PortableClassLibrary project has not been applied refactoring measures.

• https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Frameworks/PortableClassLibrary/PCLPublic/Dto/DTTables.cs#L184
• https://github.com/OpenTouryoProject/OpenTouryo/blob/develop/root/programs/C%23/Frameworks/PortableClassLibrary/PCLPublic/Dto/DTTables.cs#L335

Business.csproj (AsyncProcessingService)

\root\programs\C#\Frameworks\Infrastructure\Business\Business.csproj

SQL to be used by Infrastructure.Business.AsyncProcessingService are specified in both the EmbeddedResource and CopyToOutputDirectory. In the current setting, SQL will be output to the build output. If not needed, I want to cancel the CopyToOutputDirectory setting.

  <ItemGroup>
    <EmbeddedResource Include="..\..\..\..\..\files\resource\Sql\sqlserver\AsyncProcessingService\AsyncProcessingServiceInsert.sql">
      <Link>AsyncProcessingService\AsyncProcessingServiceInsert.sql</Link>
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </EmbeddedResource>
    <EmbeddedResource Include="..\..\..\..\..\files\resource\Sql\sqlserver\AsyncProcessingService\SelectCommand.sql">
      <Link>AsyncProcessingService\SelectCommand.sql</Link>
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </EmbeddedResource>
    <EmbeddedResource Include="..\..\..\..\..\files\resource\Sql\sqlserver\AsyncProcessingService\SelectTask.sql">
      <Link>AsyncProcessingService\SelectTask.sql</Link>
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </EmbeddedResource>
    <EmbeddedResource Include="..\..\..\..\..\files\resource\Sql\sqlserver\AsyncProcessingService\UpdateTaskCommand.sql">
      <Link>AsyncProcessingService\UpdateTaskCommand.sql</Link>
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </EmbeddedResource>
    <EmbeddedResource Include="..\..\..\..\..\files\resource\Sql\sqlserver\AsyncProcessingService\UpdateTaskFail.sql">
      <Link>AsyncProcessingService\UpdateTaskFail.sql</Link>
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </EmbeddedResource>
    <EmbeddedResource Include="..\..\..\..\..\files\resource\Sql\sqlserver\AsyncProcessingService\UpdateTaskProgress.sql">
      <Link>AsyncProcessingService\UpdateTaskProgress.sql</Link>
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </EmbeddedResource>
    <EmbeddedResource Include="..\..\..\..\..\files\resource\Sql\sqlserver\AsyncProcessingService\UpdateTaskRetry.sql">
      <Link>AsyncProcessingService\UpdateTaskRetry.sql</Link>
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </EmbeddedResource>
    <EmbeddedResource Include="..\..\..\..\..\files\resource\Sql\sqlserver\AsyncProcessingService\UpdateTaskStart.sql">
      <Link>AsyncProcessingService\UpdateTaskStart.sql</Link>
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </EmbeddedResource>
    <EmbeddedResource Include="..\..\..\..\..\files\resource\Sql\sqlserver\AsyncProcessingService\UpdateTaskSuccess.sql">
      <Link>AsyncProcessingService\UpdateTaskSuccess.sql</Link>
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </EmbeddedResource>
  </ItemGroup>

AsyncSvc_sample

AsyncSvc_sample solution could not be build.

AsyncSvc_sample.csproj

• \root\programs\C#\Samples\AsyncSvc_sample\AsyncSvc_sample\AsyncSvc_sample.csproj

contains a reference of

AsyncProcessingService.dll

• \root\programs\C#\Frameworks\Infrastructure\Framework\AsyncProcessingService\AsyncProcessingService\bin\Debug\AsyncProcessingService.dll

How do you generated the AsyncProcessingService.dll ?
Does this have been described in the procedure document ?

In addition, AssemblyInfo.cs of TestAsyncSvc_Sample project has not been committed.

Status

DTTables

Completed.

• cd4ad19
• b4a08d8
• OpenTouryoProject/OpenTouryoTemplates@e10fd59
• OpenTouryoProject/OpenTouryoTemplates@40a8720

Business.csproj (AsyncProcessingService)

Completed.

• cdf4428
• OpenTouryoProject/OpenTouryoTemplates@5e849bb

AsyncSvc_sample

Completed.

• #110

[supragyan]

@daisukenishino
We have completed jQGrid + JSON.NET for vb version.

Targetframework of ASP.NET had been hope the .NET ver3.5 but had been changed to the .NET ver4.0. However, the requested processing of jQGrid + JSON.NET seems to be the need .NET ver4.0.

but after tested we confirmed Targetframework of ASP.NET needs v4.0 for jQGrid + JSON.NET

There was a contradiction to the my request.

Shall we change version 3.5 to 4.0 and commit or do we need to commit in OpenTouryoProject/OpenTouryoTemplates.

Please confirm

[daisukenishino]

@supragyan

Thank you for research.

"/OpenTouryoProject/OpenTouryo/" is already reverted.
The changes are merged into the "/OpenTouryoProject/OpenTouryoTemplates/".

According to the following Issue of No.3,
please merge this change to the VB version of the "/OpenTouryoProject/OpenTouryoTemplates/".
I want to provide the following changes to VB version. Issue #105

[supragyan]

@daisukenishino

We have folked from OpenTouryoProject/OpenTouryoTemplate to SymphonyTeleca/OpenTouryoTemplate.

Please create nishino branch in SymphonyTeleca/OpenTouryoTemplate to create pull request for JQGrid+JSON in vb.net

Regards,

[supragyan]

@daisukenishino ,

AsyncSvc_sample solution could not be build.
AsyncSvc_sample.csproj

• \root\programs\C#\Samples\AsyncSvc_sample\AsyncSvc_sample\AsyncSvc_sample.csproj

contains a reference of

AsyncProcessingService.dll

• \root\programs\C#\Frameworks\Infrastructure\Framework\AsyncProcessingService\AsyncProcessingService\bin\Debug\AsyncProcessingService.dll

Yes, AsyncSvc_Sample contains AsyncProcessingService.dll earlier.

How do you generated the AsyncProcessingService.dll ?

We have created AsyncProcessingParameterValue.cs and AsyncProcessingServiceReturnValue.cs, LayerB, LayerD in Infrastructure/Framework/AsyncProcessingService as per your instruction.

Then to test this we have created sample class library, build and used this dll in AsyncSvc_Sample project. We have not committed AsyncProcessingService.dll because user can customize in user program.

Shall we commit AsyncProcessingService.dll ?

Does this have been described in the procedure document ?

Yes,It has described in Procedure document.

Is this ok or do we need to change anything.

Please confirm.

[daisukenishino2]

@supragyan

Shall we commit AsyncProcessingService.dll ?

Do not commit the DLL.

We will check the specifications of AsyncSvc_sample again.

• It consists of two project.
  • The first project is only put the record of the task, and to see the results.
  • The second project is to implement the B layer and the D layer that will be called from the asynchronous processing service.
• Layer B and D layers for accessing the control table to use the components in　Infrastructure/Framework/AsyncProcessingService. Therefore, D layer for access to the management table in AsyncSvc_sample will not be created.
• It'll explain how to end and how to update the progress rate in this.
  • Successful completion.
  • Abnormal termination.
    • How to throw an exception if abnormal termination.
    • How to throw an exception if you want to retry.
      And, the point of start processing of the case that resume from the middle of the processing at retry.

Please make sure to @SandeepNayak077 if there is a point of uncertainty.

[supragyan]

@daisukenishino

• it consists of two project.
  • The first project is only put the record of the task, and to see the results.

Yes in /Samples/AsyncSvc_sample/TestAsyncSvc_Sample/
it contains only insert task that will be inserted record to table.

• The second project is to implement the B layer and the D layer that will be called from the asynchronous processing service.

In [/Samples/AsyncSvc_sample/AsyncSvc_sample project/](https://github.com/OpenTouryoProject/OpenTouryo/tree/develop/root/programs/C%23/Samples/AsyncSvc_sample/AsyncSvc_sample project),

it contains

• implementation of LayerB and LayerD
• B and D layers accessing the table parameters by using /Infrastructure/Framework/AsyncProcessingService/.

As per earlier specification,
we implemented only register task in TestAsyncSvc_Sample project.

• It'll explain how to end and how to update the progress rate in this.
  • Successful completion.
  • Abnormal termination.
    • How to throw an exception if abnormal termination.
    • How to throw an exception if you want to retry.
      And, the point of start processing of the case that resume from the middle of the processing at retry.

Do we need to implement Update task in AsyncSvc_Sample project?

Please confirm ?

[daisukenishino]

@supragyan

it contains only insert task that will be inserted record to table.

OK.

As per earlier specification,we implemented only register task in TestAsyncSvc_Sample project.

OK.

Do we need to implement Update task in AsyncSvc_Sample project?

Please implement the process of updating the progress rate.
Please fill out as a comment a description of the retry processing.

// (1) First, check the progress rate, if progress rate is greater than or equal to 0%, and resume the process from there.
・・・
// (2) You will update the progress rate.
・・・
// (3) If the retry possible exception occurs, please throw the BusinessapplicationException.
・・・

[supragyan]

@daisukenishino

(1)

Layer B and D layers for accessing the control table to use the components in　Infrastructure/Framework/AsyncProcessingService.

We must use layerB and layerD components from Infrastructure/Busines/AsyncProcessingService.
because Infrastructure/Framework/AsyncProcessingService raises circular reference exception as we discussed earlier with the team.

(2)

Therefore, D layer for access to the management table in AsyncSvc_sample will not be created.

We must remove LayerD from AsyncSvc_Sample.

(3)

LayerB in AsyncSvc_Sample must perform following functionalties:

• Successful completion.
• Abnormal termination.
  • How to throw an exception if abnormal termination.
  • How to throw an exception if you want to retry.
  • And, the point of start processing of the case that resume from the middle of the processing at retry.

Shall we include Serialization and Deserialization functionalities in LayerB of AsyncSvc_Sample?

Please confirm our understanding.

[daisukenishino2]

@supragyan

because Infrastructure/Framework/AsyncProcessingService raises circular reference exception as we discussed earlier with the team.

It has error about my description. However, In the first place, I think the "Infrastructure/Framework/AsyncProcessingService" should be deleted.

Shall we include Serialization and Deserialization functionalities in LayerB of AsyncSvc_Sample?

Of course.

The implementation standards of asynchronous task must be implemented in the sample.
And implementation standards is also described in the procedure manual.