Comments (5)
Fwiw, there is now a Travis check against such IDs, so most of our documents are now checked for this.
from geekodoc.
Maybe it is not such a good idea to do that in the schema and the Travis-based solution is better suited for this issue anyway because it is less fix than the schema and because we'd immediately invalidate a ton of existing documents that validated before.
I almost think we should close this one. @tomschr ?
from geekodoc.
@sknorr
I can understand that it gives mixed feelings (because it invalidates valid documents). Same with me.
Nevertheless, I think it is a good idea. I run into the trap with one of my files and asking myself what I did wrong. I found it later in Travis. IMHO, I think, we shouldn't have two validations which exists in parallel: a local one and a remote one in Travis. IMHO both must report the same (there may be valid exception to this rule). So faster reporting of such errors is a good thing.
On the other side, I see the problem with former documents. With this change they may be invalid now. This is probably a bad thing. However, we could do:
- Raise the major version of Geekodoc to indiciate, there is an incompatible change.
- Communicate the change on doku-intern, get feedback, raise awareness etc.
- Write a conversation script (XSLT, bash, ...) which converts all attribute values of
xml:id
andlinkend
. Didn't you do that already?
We could also deal with this change on a packaging level. For example, we could introduce a geekodoc2
package which could co-exist with the (now) old geekodoc
. Same like with DocBook 4.x and 5.x. They all co-exist peacefully.
I would suggest, let's discuss this in person (faster, easier).
from geekodoc.
Revisiting this issue in the light of openSUSE/daps#566. To use the ID checks in Travis this can be replicated in GeekoDoc as well.
Tested it with this snippet of RNC code:
include "docbookxi.rnc"
{
db.xml.id.attribute =
## Identifies the unique ID value of the element
attribute xml:id {
xsd:ID { pattern = "[\-a-zA-Z0-9]+" } }
}
It validates an xml:id of foo-bar
successfully with jing, but not foo.bar
.
from geekodoc.
That is imo definitely a better solution than using DAPS itself for this purpose, thanks. Regex looks good too (though I wonder if the leading \ in the character set is necessary -- but maybe that is necessary because the RNG regex syntax is a bit weird).
from geekodoc.
Related Issues (20)
- Disallow figure and allow informalfigure in tables/entrys
- Validate width attribute in imagedata
- Add para support for variable list HOT 1
- Make empty inline elements fail to validate HOT 1
- Validate <meta> metadata HOT 2
- Adapt GeekoDoc to 5.2CR3 HOT 1
- Create a "latest" link pointing to the latest GeekoDoc HOT 2
- Disallow admon nesting HOT 5
- Disallow xml:id on listitems HOT 1
- Disallow formal elements in admons HOT 4
- Allow othername & lineage HOT 6
- Include ITS schema for GeekoDoc 2 HOT 1
- Switch from master to main as default branch HOT 1
- Make it possible to define multiple products for the same document HOT 6
- Allow footnote HOT 4
- Restrict character set of profiling attributes HOT 9
- Support videoobject to allow screencasts
- Remove indexterm element HOT 1
- Create set of metadata for <info>
- Make chapter abstracts mandatory, restrict them to one para with 150 characters HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from geekodoc.