openstack-k8s-operators / lib-common Goto Github PK
View Code? Open in Web Editor NEWCommon library for OpenStack K8s Operators
License: Apache License 2.0
Common library for OpenStack K8s Operators
License: Apache License 2.0
There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.
Error type: Cannot find preset's package (github>openstack-k8s-operators/renovate-config)
While looking into nodes failure detection and pods failover behavior/performance we stumbled upon:
https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/
The tolerationSeconds parameter allows you to specify how long a pod stays bound to a node that has a node condition. If the condition still exists after the tolerationSeconds period, the taint remains on the node and the pods with a matching toleration are evicted. If the condition clears before the tolerationSeconds period, pods with matching tolerations are not removed.
afaicu we don't explicitly set this tolerationSeconds value anywhere so it means each pod uses a default of 300s , resulting in workloads potentially taking more than five minutes to be rescheduled.
We are planning to document this and provide recommendations on how to accelerate the failover if required, still we thought it was worth bringing this up to see if we want to expose this parameter so that each operator can eventually set a more appropriate default value.
Here the code uses h.GetBeforeObject().GetName() as the name of the new MariaDBDatabase CR
lib-common/modules/database/funcs.go
Lines 119 to 128 in 66e396f
then later it uses the Database.databaseName as the name to look up the MariaDBDatabase CR
lib-common/modules/database/funcs.go
Lines 217 to 225 in 66e396f
So if the two name are not equal then the DB creation fails. I suggest to always used the database.databaseName.
lib-common/.pre-commit-config.yaml
Line 2 in ea3a766
lib-common/pkg/database/funcs.go
Lines 63 to 91 in e6d7a13
As we documented in https://github.com/openstack-k8s-operators/docs/blob/main/conditions.md:
When a controller performs a task, before it starts a step condition gets initialized to Status=Unknown e.g. DBReady, DBSync, Endpoint, ServiceRegistered, โฆ
However the current lib-common code:
lib-common/modules/common/condition/funcs.go
Lines 80 to 83 in 903adc9
Repo could use workspace to handle multiple modules. Workspaces were introduced in go 1.18 for use cases just like this one.[0]
This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.
These updates are awaiting their schedule. Click on a checkbox to get an update now.
These updates have all been created already. Click a checkbox below to force a retry/rebase of any.
k8s.io/api
, k8s.io/apiextensions-apiserver
, k8s.io/apimachinery
, k8s.io/client-go
, k8s.io/component-base
, k8s.io/utils
)modules/ansible/go.mod
gopkg.in/yaml.v3 v3.0.1
modules/certmanager/go.mod
github.com/cert-manager/cert-manager v1.11.5
github.com/go-logr/logr v1.4.2
github.com/google/uuid v1.6.0
github.com/onsi/ginkgo/v2 v2.20.0
github.com/onsi/gomega v1.34.1
go.uber.org/zap v1.27.0
k8s.io/api v0.28.12
k8s.io/apimachinery v0.28.12
k8s.io/client-go v0.28.12
k8s.io/utils v0.0.0-20240711033017-18e509b52bc8@18e509b52bc8
sigs.k8s.io/controller-runtime v0.16.6
github.com/k8snetworkplumbingwg/network-attachment-definition-client v1.4.0
k8s.io/apiextensions-apiserver v0.28.12
k8s.io/component-base v0.28.12
k8s.io/klog/v2 v2.110.1
modules/common/go.mod
github.com/go-logr/logr v1.4.2
github.com/google/uuid v1.6.0
github.com/k8snetworkplumbingwg/network-attachment-definition-client v1.4.0
github.com/onsi/ginkgo/v2 v2.20.0
github.com/onsi/gomega v1.34.1
github.com/pkg/errors v0.9.1
go.uber.org/zap v1.27.0
gopkg.in/yaml.v3 v3.0.1
k8s.io/api v0.28.12
k8s.io/apimachinery v0.28.12
k8s.io/client-go v0.28.12
k8s.io/utils v0.0.0-20240711033017-18e509b52bc8@18e509b52bc8
sigs.k8s.io/controller-runtime v0.16.6
k8s.io/apiextensions-apiserver v0.28.12
k8s.io/component-base v0.28.12
k8s.io/klog/v2 v2.110.1
modules/openstack/go.mod
github.com/go-logr/logr v1.4.2
github.com/gophercloud/gophercloud v1.14.0
k8s.io/api v0.28.12
k8s.io/apiextensions-apiserver v0.28.12
k8s.io/apimachinery v0.28.12
k8s.io/client-go v0.28.12
k8s.io/component-base v0.28.12
k8s.io/klog/v2 v2.110.1
k8s.io/utils v0.0.0-20240711033017-18e509b52bc8@18e509b52bc8
sigs.k8s.io/controller-runtime v0.16.6
modules/storage/go.mod
github.com/onsi/gomega v1.34.1
k8s.io/api v0.28.12
github.com/onsi/ginkgo/v2 v2.20.0
k8s.io/apimachinery v0.28.12
k8s.io/klog/v2 v2.110.1
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.