Water level 0% doesn't stop programs about opensprinkler-firmware

[brentos99]

looking at the code i suspect the issue might be the following, but i've never played with C++ before and i cannot debug it myself..

main.cpp - line 440

         if (prog.use_weather) {
            byte wl = os.options[OPTION_WATER_PERCENTAGE];
            _water_time = water_time * wl / 100;_  **This could be an issue as water_time * 0 / 100 (in my head) should throw an error**
            if (wl < 20 && water_time < 10) // if water_percentage is less than 20% and water_time is less than 10 seconds
                                            // do not water
              water_time = 0;
          }

[brentos99]

Actually thinking about the above overnight I stuffed up my maths. I will look to see if there is something else that might be causing my bug. Unless somebody else can find it first