opensourcesys / speechlogger Goto Github PK

Reading in Windows Notepad (and maybe other apps, but I haven't found any yet), results in unexpected blank lines in the log.

Expected and actual:

This
is
a
test

Actual logged result:

This


is


a


test

Other notes:

Tested in Ms. Word, and this doesn't happen there. Nor on the desktop.
Suspect it is some relationship to \r\n being passed in.

Evidently, speech.speech.speak, is not used by say-all. Therefore speech derived from saying all is not logged.

Reported indirectly by a question on a users' list, about why the speech History add-on didn't include say-all speech.

First of all, thank you for this addon!

I would love to be able to put date/time variables in the log filename. Or, a setting to create a new file each day or session or something -- I'd be fine with even a new file each session, if that's simpler/more doable than allowing date/time variables in the filename.

I'm afraid I don't have a clue how to do this! -- I googled a bit, this seeeeems potentially useful:
https://serverfault.com/questions/16706/current-date-in-the-file-name

In unix, for my bash histories filename, the setting goes like this:

HISTFILE=/home/$USER/.histories/.bash_history-$(date "+%Y%m%d")

If nothing else, hopefully this ^^ example helps clarify what I'm talking about.

Thanks again!

So, I have a small PC I use as a server, and I gave remote access to a few trusted people. Just in case, I would appreciate an option to make speech logging start right after nvda starts up with out a need to press any key combo. This will be usefull for example after windows finishes updating and restarts itself. I'm talking about local speech logging. It would also be cool that each time nvda is restarted a new file with the date and time is being made. That would make browsing through logs easier.

Hi

When navigating in edit fields, I get the following error with last alpha (commit 40023954726e9b85225a3fb77c3545d8c6f753f1):

ERROR - scriptHandler.executeScript (10:59:24.684) - MainThread (2816):
error executing script: <bound method EditableText.script_caret_moveByCharacter of <NVDAObjects.Dynamic_EditableTextLogContainerIAccessibleEditWindowNVDAObject object at 0x1290AE50>> with gesture 'flèche droite'
Traceback (most recent call last):
  File "scriptHandler.py", line 295, in executeScript
    script(gesture)
  File "editableText.py", line 239, in script_caret_moveByCharacter
    self._caretMovementScriptHelper(gesture, textInfos.UNIT_CHARACTER)
  File "editableText.py", line 174, in _caretMovementScriptHelper
    self._caretScriptPostMovedHelper(unit,gesture,newInfo)
  File "NVDAObjects\behaviors.py", line 220, in _caretScriptPostMovedHelper
    super()._caretScriptPostMovedHelper(speakUnit, gesture, info)
  File "editableText.py", line 160, in _caretScriptPostMovedHelper
    speech.speakTextInfo(info, unit=speakUnit, reason=controlTypes.OutputReason.CARET)
  File "speech\speech.py", line 1248, in speakTextInfo
    speak(seq, priority=priority, suppressBlanks=suppressBlanks)
  File "C:\Users\Cyrille\AppData\Roaming\nvda\addons\instantTranslate\globalPlugins\instantTranslate\__init__.py", line 287, in _localSpeak
    self._speak(sequence, *args, **kwargs)
  File "C:\Users\Cyrille\AppData\Roaming\nvda\addons\speechHistory\globalPlugins\speechHistory.py", line 100, in mySpeak
    self.oldSpeak(sequence, *args, **kwargs)
  File "C:\Users\Cyrille\AppData\Roaming\nvda\addons\speechHistoryExplorer\globalPlugins\speechHistoryExplorer\__init__.py", line 138, in mySpeak
    self.oldSpeak(sequence, *args, **kwargs)
TypeError: new_speak() got an unexpected keyword argument 'suppressBlanks'

There are other running add-ons (and some of them patch speech.speak, but disabling yours fixes the issue.

It's very likely a consequence of #13483.

You should probably take and pass *args and **kwargs when patching a function.

It has not been expressed explicitly but I would say that it has been the usage that new optional parameters can be added to the signature of a function without breaking the API. If you disagree and feel that the API has been broken, feel free to discuss it with NVAccess and / or on the lists.