Return doesn't work about opensourcepos

[jekkos]

I suppose it has always been that way. Returning sales is ought to be done with a barcode scanner, as the receipts have the POS sale_id identifier encoded in that barcode. The valid_receipt will only be true if you type in the full POS number. In that case you should get the autocomplete suggestion (probably just one in this case). Haven't got the time to test this now but can you confirm if it works this way?

In other words the suggestion for return should only show up once the complete POS is typed in.

[kagarwala]

I tested it without any of my changes with a new ospos code base.
I made my first sale. The sale_id which showed in receipt was, 'POS 1'

I pasted the same while returning..Auto-complete didn't show up...
There was a JS error too...

But if you just press enter or try to add the sale_id even though auto-complete didn't show up...It is able to add the sale in return...

I guess that's because add_item is working because we entered the complete and valid sale_id...

[jekkos]

I just tried to reproduce what you did here and indeed, no suggestion showing up. However from reading the code it looks like there should be at least one. I'll look into once I have my debugger running.

[kagarwala]

The code I posted above might fix this issue...I added this to master branch on github and it worked.

Can you please tell me, which branch is the stable one...master/feature ... I am new to Git...

Or should I just stick to a released 2.31 version...???

[jekkos]

master is the most current development branch. feature branch contains some modifications I plan to integrate sooner or later (unfinished work)

[jekkos]

I did a proper fix in b29cb85 by changing the javascript parsing on the client side. This fix is better as it give the server more flexibility in what it can send back (we shouldn't require two fields all the time).