Comments (4)
Ok !
You can move your code from the UI to the MolComponentManager, and execute related unit-tests to confirm the patch :-)
from molecule.
Thanks Samuel.
Note : that's not a bug, the cleanUp clean only the current session of the ComponentManager (and also itself).
Some objects instances are not yet clean by the garbage collector, due to Smalltalk environement mecanism, I don't know when it's do but probably follwing a garbage cleanup policie. This is a new feature that consist to force the garbaging of stopped components when the ComponentManager>>cleanUp is done (for example).
from molecule.
I think this is better to do the garbageCollector by the ComponentManager, I think by the UI (on the menu) this is not the good place. UI need to show us a real state of the Component system and interferate the less (this is just a view). If there is some lost instances we need to clean that by a controller (I suggest the componentmanager) but not by calling only a UI function.
So, what do you think about grab the cleanup part of MolComponentManager>>flashComponents and to do the same thing at the end of the MolComponentManager>>cleanUp ? With that when you clean the system all stopped components will be automatically removed.
from molecule.
Yes it's probably a better solution to do the garbage collector after cleanUp, than before opening the UI.
It will permit to cleanUp instances that are lost with the others, and that's better !
Your solution is good and better. So, let's go for that ?
from molecule.
Related Issues (20)
- enhancement - Better world menu HOT 2
- [IDE] bug - world menu - "No Components are running" HOT 3
- Feature : using Pharo "Do image Cleanup" to cleanup Molecule
- Cannot add (but remove) some events producers HOT 1
- Provided Events should be received after subscription enabling
- Cannot unsubscribe an originator to a receiver HOT 1
- Event from stopped component not reconnected when restarted.
- Bug: different types can be used for the name of a component when creating or calling it HOT 3
- Getting services and/or parameters not return "notFound" interface when the name is wrong
- Components are not re-defined when a new molecule version is loaded
- Remove forked component update when system annoucement are triggered HOT 2
- Exception on building contextual menu (right click) HOT 1
- #SearchFacade is missing when opening define a component menu HOT 2
- Centralize the default component name into a utility class
- Bug when remove an event producer named #default HOT 1
- How to use multiple services and events providers ?
- Catch exceptions when cleanUp is used from the main menu HOT 1
- Molecule-IDE tests are not executed by CI HOT 1
- Cannot load Pyramid-Examples HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from molecule.