EloquentQueryProvider about datatable

[timgws]

We should consider allowing a maximum value for skip and limit.

For example, I don't want users to be able to export all of my data by just having them provide me with a $largeNumber for the take parameter.

But I don't think this needs to be handled in the QueryProvider, I think this should be done somewhere else, that way the providers don't need to worry about handling minimum and maximum parameters, it happens somewhere in a level above.

[timgws]

Are you specifically talking about Chumper/Datatable#267?

I also see a problem if the user pre selected any data and then passes it to the EloquentQueryProvider.

E.g. if a user passes all users sorted by name to the datatable but skips the first 10 we have a problem, because the initial dataset can change.

I don't see that as a bug - I see that as a feature :) By definition, if you are doing filtering & ordering, the datatable should represent what is in the database. If that means unexpectedly showing and hiding different rows from users, then so be it :)

I am sure if it's a problem that we will hear about it.

[Chumper]

I was not talking about any issue specifically, that was just my impression when working on the old 'QueryEngine`.

Sounds good, I think with the current eloquent there should be quite some possibilities.