Comments (3)
We should consider allowing a maximum value for skip
and limit
.
For example, I don't want users to be able to export all of my data by just having them provide me with a $largeNumber
for the take
parameter.
But I don't think this needs to be handled in the QueryProvider
, I think this should be done somewhere else, that way the providers don't need to worry about handling minimum and maximum parameters, it happens somewhere in a level above.
from datatable.
Are you specifically talking about Chumper/Datatable#267?
I also see a problem if the user pre selected any data and then passes it to the EloquentQueryProvider.
E.g. if a user passes all users sorted by name to the datatable but skips the first 10 we have a problem, because the initial dataset can change.
I don't see that as a bug - I see that as a feature :) By definition, if you are doing filtering & ordering, the datatable should represent what is in the database. If that means unexpectedly showing and hiding different rows from users, then so be it :)
I am sure if it's a problem that we will hear about it.
from datatable.
I was not talking about any issue specifically, that was just my impression when working on the old 'QueryEngine`.
Sounds good, I think with the current eloquent there should be quite some possibilities.
from datatable.
Related Issues (20)
- CollectionProvider should take the individual column search settings into consideration
- `CollectionProvider` should support custom order functions
- Add Datatable 1.10 support
- [CollectionProvider] The search function should be handed the raw model
- OpenSkill does not work with symfony/http-foundation ~3.0 HOT 4
- [QueryBuilderProvider] Datatable::query ? HOT 7
- Allow http-foundation 2.8.* for better compatibility with Laravel 5.2 HOT 6
- [CollectionProvider] Returned columns are empty HOT 6
- [CollectionProvider] Sorting does not work as expected HOT 4
- Tag and Release Version 0.3.0? HOT 1
- Make VersionEngine configurable HOT 2
- Illuminate\Support\Collection::reject is not supported in collections w/ Laravel 4.2 HOT 2
- [CollectionProvider] Support pagination HOT 15
- [CollectionProvider]: Need Help HOT 4
- [General] Project abandoned? HOT 5
- Call to undefined method OpenSkill\Datatable\Datatable::table()
- Just need some info Upgrading Laravel 4 - Laravel 5.5 HOT 1
- Laravel 4 Service Provider HOT 1
- Support DynaTable out of the box. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from datatable.