Coder Social home page Coder Social logo

Comments (2)

bowenlan-amzn avatar bowenlan-amzn commented on August 14, 2024 1

Did some work on this today.
Aggregation only knows the correct number of buckets for the response at the final reduce phase. Before that, aggregations are done on every shard which may lead to a larger number of buckets (larger than 65535, the limit) to reduce in the end.

if (docCounts.increment(bucketOrd, docCount) == docCount) {
// We calculate the final number of buckets only during the reduce phase. But we still need to
// trigger bucket consumer from time to time in order to give it a chance to check available memory and break
// the execution if we are running out. To achieve that we are passing 0 as a bucket count.
multiBucketConsumer.accept(0);
}

So before the reduce phase, what we can do best is to fail gracefully before OOM. Above is a snippet to do that.
I will raise a PR later to add this logic into histogram.

from opensearch.

icercel avatar icercel commented on August 14, 2024 1

@bowenlan-amzn , hi, terribly sorry for the delay, wanted to thank you for looking into this and providing a fix 🙇
can't wait to see it in AWS!

from opensearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.