Comments (5)
The backpressure works as follows and here the heap_domination threshold is mere 0.05 percent of total jvm memroy available for the process. The same flowchart is applicable for both SearchTask
s and SearchShardTask
s
There are basically three trackers which can potentially cancel a task
- Heap Based
- CPU Based
- Time Based
The basic flaw in this is even when node is not under duress because of Heap, the tracker will still kick in and cancel the task
from opensearch.
Assigning to @kaushalmahi12, due to his prior context with query sandboxing and search backpressure
from opensearch.
@kaushalmahi12 Agreed and that is what the issue is trying to explain. I think we should check the duress condition for each tracker as well. For example: If under heap duress, then only evaluate the task for heap based cancellation.
from opensearch.
Thats right @sohami
The weird thing about this is that, it takes the tasks for cancellation even when total jvm allocations by co-ordinator/shard level tasks are 0.05%. ref.
Time Based cancellation is still not justified for cases where the cluster has very light search traffic and user is fine with higher latencies for those queries (Given only CPU is high and AC is already there to safeguard against new incoming requests).
I think we should increase this threshold for search workload JVM(or remove it altogether) and separate out the corresponding trackers.
from opensearch.
[Triage - attendees 1 2 3 4 5 6 7 8]
@ticheng-aws Thanks for creating this issue, looking forward to seeing this resolved.
from opensearch.
Related Issues (20)
- [PROPOSAL] Highlight REST API Changes in PRs HOT 2
- [Remote State] Timing and tracing for RemoteWritableEntityStore
- [Remote State] Optimize diff publication
- [AUTOCUT] Gradle Check Flaky Test Report for IndicesStoreIntegrationIT
- [Automation Enhancement] Mechanism to close the created Gradle Check AUTOCUT flaky test issues. HOT 3
- [AUTOCUT] Gradle Check Flaky Test Report for RemoteStoreRestoreIT
- [AUTOCUT] Gradle Check Flaky Test Report for AzureStorageServiceTests HOT 6
- [Refactor] Consider removing the `opensearch-dashboards` module from this repo
- [BUG] Inconsistent behavior on POST _aliases when two opposing actions are operating on the same index/alias pair HOT 2
- [AUTOCUT] Gradle Check Flaky Test Report for ICacheKeySerializerTests
- [AUTOCUT] Gradle Check Flaky Test Report for LangPainlessClientYamlTestSuiteIT
- [BUG] Option in NodesStatsRequest to return per-shard stats in response
- [AUTOCUT] Gradle Check Flaky Test Report for RecoveryWhileUnderLoadIT HOT 1
- [Feature Request] Reindex should use each shard to perform slice tasks instead of coordination node
- [BUG] Parsing a GetResult returns NPE if "found" field is missing HOT 5
- [BUG] Unexpected failure while sending request, -84 is not a valid id HOT 9
- [BUG] [OPENSEARCH] [AWS] - Error while deleting snapshot on S3 HOT 1
- [RFC] - OpenSearch Table HOT 2
- [AUTOCUT] Gradle Check Flaky Test Report for PitMultiNodeIT HOT 1
- Regex Pattern in painless script in ingest pipeline giving "unexpected value type [class [Ljava.lang.String;]" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opensearch.