Comments (8)
@ruanyl Sure, done for that.
from opensearch-dashboards.
@SuZhou-Joe Could you attach a screenshot of the left navigation bar with use case(with workspace disabled)?
from opensearch-dashboards.
I like the idea but we need to make sure that the API isn't a breaking change. Based on your proposal it looks like plugins that previously showed up on the left nav will no longer show there unless they call another API. That would be a breaking change. The previous registration should still work for a plugin if this needs to go into the 2.x line
from opensearch-dashboards.
Hi @ashwin-pc , actually there is no breaking change for current application.register
interface, if an application is registered without being assigned to a group by calling addNavToGroup
, it behaves exactly the same as what it does today, display in the first-level navigation(no matter group navigation is enabled or not), under the specific category defined in application.register
. Only when an application is added to a group and the feature flag is turn on will it display in the second navigation.
from opensearch-dashboards.
@SuZhou-Joe when will this interface be ready for plugins to use?
from opensearch-dashboards.
@SuZhou-Joe when will this interface be ready for plugins to use?
Hopefully the interface and the feature flag should be ready before 06.25, depends on the PR review process.
from opensearch-dashboards.
Hi @ashwin-pc , actually there is no breaking change for current application.register interface, if an application is registered without being assigned to a group by calling addNavToGroup, it behaves exactly the same as what it does today, display in the first-level navigation(no matter group navigation is enabled or not)
Ah, sorry didnt see that in the RFC. Thanks for the clarification. Are groups distinct in the UI from apps that arent registered as a part of a group? e.g. What happens if only some applications register as a part of the group and others do not? Visually can i tell apart a group from an app that didnt register itself as a part of the group?
from opensearch-dashboards.
When new navigation is enabled
Those applications do not register as a part of the group will display in the first navigation, just like what it does today. And those do will be collapsed to second navigation. So yes, visually you can easily tell who register as group verses those do not, those do sits in second navigation while those do not sits in first navigation.
from opensearch-dashboards.
Related Issues (20)
- [Meta][VisBuilder] VisBuilder 2.0: Transition to use a single, unified visualization library and allow migration
- Hide Charts in discover
- [BUG] Overriding field type in index pattern not working as it should HOT 2
- [AUTOCUT] Distribution Build Failed for OpenSearch-Dashboards-2.16.0 HOT 1
- [Navigation-next] Add a new component to display group enabled navigation.
- [Workspace] Support global workspace
- [BUG] The line chart might clip or fail to display points at the top of the range HOT 1
- [FEATURE] Support Version Decoupling in Index Patterns Dashboards Plugin HOT 1
- [Workspace] Capabilities service add dashboard admin flag
- [BUG] Plugins cannot use `@osd/babel-preset/node_preset`
- [RFC] ScatterPlots in OSD Visualize HOT 1
- [BUG] Observability / Metrics / Source No index to be selected HOT 1
- [RFC] Dynamic Configuration Service HOT 11
- [BUG][Discover-Next] SQL and PPL bugs when integrating with MDS
- [BUG][Discover-Next] Invalid security token error when using query assist with MDS HOT 1
- [Workspace] Comply recentAccessed service with workspace
- [Navigation-Next] Support nested items in left navigation.
- [BUG] Downloading report in dark theme has header and footer alone in white background HOT 1
- [Draft][Design]Transition of Legacy Visualization to VisBuilder
- [Draft][Research]How dashboard utilize embeddable to load saved object
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opensearch-dashboards.