Coder Social home page Coder Social logo

Comments (8)

SuZhou-Joe avatar SuZhou-Joe commented on June 29, 2024 1

@ruanyl Sure, done for that.

from opensearch-dashboards.

ruanyl avatar ruanyl commented on June 29, 2024

@SuZhou-Joe Could you attach a screenshot of the left navigation bar with use case(with workspace disabled)?

from opensearch-dashboards.

ashwin-pc avatar ashwin-pc commented on June 29, 2024

I like the idea but we need to make sure that the API isn't a breaking change. Based on your proposal it looks like plugins that previously showed up on the left nav will no longer show there unless they call another API. That would be a breaking change. The previous registration should still work for a plugin if this needs to go into the 2.x line

from opensearch-dashboards.

SuZhou-Joe avatar SuZhou-Joe commented on June 29, 2024

Hi @ashwin-pc , actually there is no breaking change for current application.register interface, if an application is registered without being assigned to a group by calling addNavToGroup, it behaves exactly the same as what it does today, display in the first-level navigation(no matter group navigation is enabled or not), under the specific category defined in application.register. Only when an application is added to a group and the feature flag is turn on will it display in the second navigation.

from opensearch-dashboards.

BionIT avatar BionIT commented on June 29, 2024

@SuZhou-Joe when will this interface be ready for plugins to use?

from opensearch-dashboards.

SuZhou-Joe avatar SuZhou-Joe commented on June 29, 2024

@SuZhou-Joe when will this interface be ready for plugins to use?

Hopefully the interface and the feature flag should be ready before 06.25, depends on the PR review process.

from opensearch-dashboards.

ashwin-pc avatar ashwin-pc commented on June 29, 2024

Hi @ashwin-pc , actually there is no breaking change for current application.register interface, if an application is registered without being assigned to a group by calling addNavToGroup, it behaves exactly the same as what it does today, display in the first-level navigation(no matter group navigation is enabled or not)

Ah, sorry didnt see that in the RFC. Thanks for the clarification. Are groups distinct in the UI from apps that arent registered as a part of a group? e.g. What happens if only some applications register as a part of the group and others do not? Visually can i tell apart a group from an app that didnt register itself as a part of the group?

from opensearch-dashboards.

SuZhou-Joe avatar SuZhou-Joe commented on June 29, 2024

When new navigation is enabled

Those applications do not register as a part of the group will display in the first navigation, just like what it does today. And those do will be collapsed to second navigation. So yes, visually you can easily tell who register as group verses those do not, those do sits in second navigation while those do not sits in first navigation.

from opensearch-dashboards.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.