[BUG] Startup fails with theme overrides about opensearch-dashboards

[BionIT]

checkout a commit older than this PR would resolve thus narrow down to this PR #5652

[BionIT]

Different from the screen recording in the PR #6703

The dashboard in future playground won't display anything

[BionIT]

Found issue still happening, thus re-opened

[joshuarrrr]

@BionIT Can you provide some repro details? If I visit https://future.playground.opensearch.org, this is what I see

[BionIT]

Yep, @joshuarrrr this is after switching to an older commit than the PR which introduced the bug, otherwise, we see empty page. Please check future playground for the empty page and error now.

[joshuarrrr]

I just need more info to be able to debug it, so if there was a version that included #6703 and #5652, that would be really helpful, because it doesn't repro running locally. I can also provide some additional context:

The issue is likely not in /bootstrap.js (source: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/legacy/ui/ui_render/bootstrap/bootstrap.js.hbs ), despite that being the failure point. To start up correctly, that application requires /startup.js ( source: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/legacy/ui/ui_render/bootstrap/startup.js.hbs )to successfully load and execute first. You can see in the console that startup.js failed on an unexpected token on L15: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/legacy/ui/ui_render/bootstrap/startup.js.hbs#L15

That means that there's likely an issue with this block of code:

OpenSearch-Dashboards/src/legacy/ui/ui_render/ui_render_mixin.js

Lines 174 to 177 in b5121d3

	const configDarkMode =
	!authEnabled || request.auth.isAuthenticated
	? await uiSettings.get('theme:darkMode')
	: uiSettings.getOverrideOrDefault('theme:darkMode');

which wasn't edited, but moved in #5652

[ananzh]

@BionIT same question here, is there a way to reproduce locally or could you help to add some repro steps?

[BionIT]

To repro:

• add the commit, see empty page and error in future playground
• remove the commit, OSD bootstraps correctly in playground

I don't have bandwidth to look further, and I wonder if the change would behave different when it is in container?

[kavilla]

i think cache issue. that supercedes the cache buster for plugins.

2.13 navigate to playground/app/plugin
HTML dom gets loaded with only reference to script bootstrap
HTML dom downloads new bootstrap script due to cache busting mechanism
bootstrap statically sets that window osdThemeTag

2.14 navigate to playground/app/plugin
HTML dom gets loaded from cache since visiting again. but it only has the reference to bootstrap, and does not include startup.js
HTML dom downloads new bootstrap script due to cache busting mechanism
bootstrap expected startup.js to be downloaded and ran to set that global window value. get undefined exception

expected:
HTML dom gets loaded with both startup and bootstrap.

tbh i'm not sure if this normal issue or something special about docker's caching optimization. we could consider just adding a default value to that osdThemeTag in bootstrap if window.osdThemeTag is undefined. @joshuarrrr @ananzh.

[kavilla]

reverted in 2.14 in 2.x as @joshuarrrr is addressing existing issue that got exposed by this work but not from this work.

[BionIT]

@joshuarrrr Do we still target this fix for 2.15 or 2.16?