Coder Social home page Coder Social logo

Comments (3)

mistydemeo avatar mistydemeo commented on June 25, 2024

I see the cause of this one; I introduced this bug by accident.

The code here branches if the -zip option is selected:

if self.zip:
    self.identify_contents(filename, type=self.container_type(matches))

The type parameter is set to the type of the container, or None if the container type can't be detected by FIDO. Prior to 1b5698a, the only two values were zip and tar, but that added support for ole containers as well. FIDO uses this same method to determine container types for the purpose of identifying single files using container signatures, and for recursing into container files using -zip. It's the latter case that's breaking, since ole files are causing FIDO to try to unzip the files and identify the contents.

from fido.

mistydemeo avatar mistydemeo commented on June 25, 2024

Fixed by #73. I can confirm after that PR that -zip still works as expected on ZIP files, but no longer breaks on OLE files.

from fido.

sevein avatar sevein commented on June 25, 2024

Thanks @mistydemeo! @jhsimpson is going to merge #73 soon.

from fido.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.