Comments (14)
the build succeeded, so i uploaded a patch file here https://github.com/Lanchon/OpenPDroid-patches
from openpdroidpatches.
Okay, I see the work. Thanks for the write-up, it makes a big difference. I will review this tonight and respond. Thanks!
from openpdroidpatches.
got rid of unsafe static outer context :) now static privacy service is registered without a context. outer context was being used for privacy decisions only in TELEPHONY_SERVICE and WIFI_SERVICE. i concluded this was a mistake (were there bugs reported against these areas?) and standardized privacy decisions across all of pdroid on current context. context hell no more!
from openpdroidpatches.
FYI: finally tested (lightly) all the changes for the first time, everything seems to be working.
also, with all this poking around regarding contexts, i may have found a bug in android that seems to render the service cache ineffective. i will study this further and submit a fix to google code if confirmed.
from openpdroidpatches.
Okay. I saw you added some work, is this a natural point for me to take
a look or is more coming (on this particular issue?)
from openpdroidpatches.
im ok with the way things are now and started using it on my phone. i dont plan to clean up the code any further, too messy, but ill rebase and bugfix if necessary.
from openpdroidpatches.
Okay...the weekend is busy for me, but I haven't forgotten this. It will be looked at when I get a moment.
from openpdroidpatches.
no rush! when and if u want :)
from openpdroidpatches.
I synced my local repo today and the patches doesn't work anymore. Am i alone?
Nevermind, seems to be my fault.
I tried to add support for my "grouper" to my local repo and this caused the probs. I deleted the whole dir and resynced again. Patches are working again.
from openpdroidpatches.
if you are patching CM11, go here:
https://github.com/Lanchon/OpenPDroid-patches
from openpdroidpatches.
Lanchon, I have owed you a code review for forever and haven’t had the time. If you’d like, post a link to your changes (I couldn’t find where the pull request was the other day) and I will push them into master today. Sorry for the wait.
from openpdroidpatches.
never mind, it seems today the patches are broken again
from openpdroidpatches.
@Lanchon I posted an update to my comment. Seems to be my fault.
Or did you have probs on your own?
from openpdroidpatches.
already answered you on xda
from openpdroidpatches.
Related Issues (20)
- Enforcing READ_PHONE_STATE privacy is unnecessary complicated HOT 13
- Working together on one framework. HOT 14
- Merging PD2.0 into OPD HOT 2
- IMPORTAND - Further development HOT 6
- pdroid patched HOT 6
- New Founctions and Problems HOT 5
- openpdroid and cell location
- App detected my device model - OpenPDroid not working? HOT 1
- How to do build process HOT 5
- LG G2 build HOT 1
- next release HOT 7
- patches broke for CM11-M6 HOT 4
- Gerrit hosting HOT 23
- Iptables command permission check HOT 7
- Split off patches
- Useless privacy.x509.pem HOT 2
- Consistent coding style, get rid of markers HOT 34
- ProcessManager.exec validation is possibly insecure HOT 7
- Log and Camera permissions can be bypassed HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openpdroidpatches.