proposed changes to OPD about openpdroidpatches

[Lanchon]

the build succeeded, so i uploaded a patch file here https://github.com/Lanchon/OpenPDroid-patches

[mateor]

Okay, I see the work. Thanks for the write-up, it makes a big difference. I will review this tonight and respond. Thanks!

[Lanchon]

got rid of unsafe static outer context :) now static privacy service is registered without a context. outer context was being used for privacy decisions only in TELEPHONY_SERVICE and WIFI_SERVICE. i concluded this was a mistake (were there bugs reported against these areas?) and standardized privacy decisions across all of pdroid on current context. context hell no more!

[Lanchon]

FYI: finally tested (lightly) all the changes for the first time, everything seems to be working.

also, with all this poking around regarding contexts, i may have found a bug in android that seems to render the service cache ineffective. i will study this further and submit a fix to google code if confirmed.

[mateor]

Okay. I saw you added some work, is this a natural point for me to take
a look or is more coming (on this particular issue?)

[Lanchon]

im ok with the way things are now and started using it on my phone. i dont plan to clean up the code any further, too messy, but ill rebase and bugfix if necessary.

[mateor]

Okay...the weekend is busy for me, but I haven't forgotten this. It will be looked at when I get a moment.

[Lanchon]

no rush! when and if u want :)

[danizwam]

I synced my local repo today and the patches doesn't work anymore. Am i alone?

Nevermind, seems to be my fault.

I tried to add support for my "grouper" to my local repo and this caused the probs. I deleted the whole dir and resynced again. Patches are working again.

[Lanchon]

if you are patching CM11, go here:
https://github.com/Lanchon/OpenPDroid-patches

[mateor]

Lanchon, I have owed you a code review for forever and haven’t had the time. If you’d like, post a link to your changes (I couldn’t find where the pull request was the other day) and I will push them into master today. Sorry for the wait.

[Lanchon]

never mind, it seems today the patches are broken again

[danizwam]

@Lanchon I posted an update to my comment. Seems to be my fault.

Or did you have probs on your own?

[Lanchon]

already answered you on xda