Coder Social home page Coder Social logo

Comments (8)

jayshao avatar jayshao commented on August 30, 2024

This seems challenging from a compatibility perspective due to the "string value" being presumably machine-readable.

I think all current implementations actually use the IDs... if we were able to survey enough people I wonder if we could deprecate the "String Value" to allow for internationalization and future re-wording (as long as the semantics aren't changed, which I think would be the case in this case)

If that were the case, I think we could just change the description name - which would probably be fine

from venue-taxonomy.

christiancollins11 avatar christiancollins11 commented on August 30, 2024

Agreed. Vistar makes no use of the "string value" in integrations and would support deprecating.

from venue-taxonomy.

ndbabb avatar ndbabb commented on August 30, 2024

Agree and support deprecating string values as well.

from venue-taxonomy.

mowasfi7 avatar mowasfi7 commented on August 30, 2024

Agree. Verizon Media uses IDs rather than string values.

from venue-taxonomy.

mercurim avatar mercurim commented on August 30, 2024

-1, can shed more light when I receive confirmation, but some DSPs consume string. I am in the process of getting them to look at the repo. There are use cases within Samsung where this value is needed.

from venue-taxonomy.

bruno8g avatar bruno8g commented on August 30, 2024

Agreed to deprecate string values.

from venue-taxonomy.

jayshao avatar jayshao commented on August 30, 2024

@mercurim I think that if that's the case, if we "deprecate" that gives us the flexibility to not keep the strings in sync with the descriptions - or to announce some multiple release-cycle period when they might be removed (e.g. deprecated in 1.1, removed in... 1.3 or 1.4 towards the end of the year)

My worry is - with the strings, we will increasingly be caught in a case where the strings cannot match the descriptions if they change (or we have to have a lot of churn with deprecating and replacing categories) which I think makes them limited utility as we go forward.

from venue-taxonomy.

jayshao avatar jayshao commented on August 30, 2024

Did a simple edit w/o changing the strings... though I wonder if we might want to add some guidance... somewhere around whether the location is "primarily" a gas station that also has an attached convenience store... or primarily a convenience store that also sells gas. Perhaps a test/guidance based on where the majority of the revenue comes from?

from venue-taxonomy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.