Comments (8)
This seems challenging from a compatibility perspective due to the "string value" being presumably machine-readable.
I think all current implementations actually use the IDs... if we were able to survey enough people I wonder if we could deprecate the "String Value" to allow for internationalization and future re-wording (as long as the semantics aren't changed, which I think would be the case in this case)
If that were the case, I think we could just change the description name - which would probably be fine
from venue-taxonomy.
Agreed. Vistar makes no use of the "string value" in integrations and would support deprecating.
from venue-taxonomy.
Agree and support deprecating string values as well.
from venue-taxonomy.
Agree. Verizon Media uses IDs rather than string values.
from venue-taxonomy.
-1, can shed more light when I receive confirmation, but some DSPs consume string. I am in the process of getting them to look at the repo. There are use cases within Samsung where this value is needed.
from venue-taxonomy.
Agreed to deprecate string values.
from venue-taxonomy.
@mercurim I think that if that's the case, if we "deprecate" that gives us the flexibility to not keep the strings in sync with the descriptions - or to announce some multiple release-cycle period when they might be removed (e.g. deprecated in 1.1, removed in... 1.3 or 1.4 towards the end of the year)
My worry is - with the strings, we will increasingly be caught in a case where the strings cannot match the descriptions if they change (or we have to have a lot of churn with deprecating and replacing categories) which I think makes them limited utility as we go forward.
from venue-taxonomy.
Did a simple edit w/o changing the strings... though I wonder if we might want to add some guidance... somewhere around whether the location is "primarily" a gas station that also has an attached convenience store... or primarily a convenience store that also sells gas. Perhaps a test/guidance based on where the majority of the revenue comes from?
from venue-taxonomy.
Related Issues (20)
- Add: Retail > Malls > Normalize Mall Grandchildren HOT 1
- Add: Transit ->Travel Plaza HOT 4
- Add: Transit -> EV Charging Stations HOT 6
- Add: Point of Care > Hospitals HOT 3
- Remove deprecated string formats HOT 1
- Align wire protocol with OpenRTB 2.6-202211 HOT 1
- Add "Retail" > "Big Box"
- Add "Retail" > "Discount Store" HOT 1
- Transit_Airport_Parking Space
- Adding Window Shops as a GC category HOT 2
- Health and Beauty_Fitness Studios
- Add: "Health and Beauty" > "Indoor Sports Hall"
- Add: Office Buildings_Coworking Space
- Introduce a 0 in front of parent types HOT 3
- Pharmacies in Retail Grocery HOT 4
- Add: "Retail" > "Tobacco Shop" HOT 1
- Add: Shooting Range as a Category HOT 1
- Add "Retail" > "Laundromats"
- Add "Transit" > "Trams"
- Add "Transit" > "Train Stations" > "Escalators"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from venue-taxonomy.