Comments (4)
eddiecohen
commented on July 18, 2024
Fixed in 69dff6e. Thanks!
from openni2.
elfring
commented on July 18, 2024
Thanks for your source code improvement.
This update seems to be incomplete so far.
- I find a name like "VIEWER_H" too short here. How do you think about to make your include guards not only standard-compliant but also really unique by appending a kind of UUID?
- Would you also like to improve identifiers like "
_OniFrameSync" and "_BM_REQUEST_TYPE"?
from openni2.
eddiecohen
commented on July 18, 2024
- Viewer.h is an internal include file, not to be used from another project, so I don't think it's really an issue.
- UUID are a bit too much IMO.
- usb200.h (which contains _BM_REQUEST_TYPE) is a file taken from Windows DDK (despite what it says in its header), I prefer not to change it.
- Regarding "hidden" struct names (like _OniFrameSync) - you're right. I'll fix that as well.
from openni2.
piedar
commented on July 18, 2024
#pragma once is supported by every major compiler and is in several ways superior to #include guards.
from openni2.
Related Issues (20)
- How can I install OpenNI2 on Centos7
- structure sensor on jetson tx1 (aarch64) HOT 6
- How to export Openni2 on an embedded board (running Angstrom Linux) HOT 1
- libusb_init fails
- Where's GlobalDefaults.ini under Ubuntu 12.04 64 bits?
- NiViewer has no GUI HOT 2
- SimpleViewer using Xtion2 error HOT 1
- OpenNI Viewer crashes with Xtion2
- Reconnection loop to the sensor HOT 1
- Can I use OpenNI2 to align the RGB and the depth vedio? HOT 1
- Hello 2020
- Failed to write core dump. Minidumps are not enabled by default on client versions of Windows
- OpenNIError: (OniStatus.ONI_STATUS_BAD_PARAMETER, b'Device.setProperty(5) failed', None) HOT 2
- Trouble connecting LIPSedge L210u with Jetson AGX Xavier
- can't open Device on Nexus 5 with Lollipop 5.0 HOT 1
- Kinect on OS X error "unable to claim interface: -7"
- Where can I find sigmanil?
- readFrame(VideoFrameRef* pFrame). Does this keep a backlog of frames or do I get the most recent frame
- how to convert cv::mat to open::videostream HOT 2
- SimpleViewer: Device open failed: HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openni2.