Unit Testing about openloco

[IntelOrca]

Just go with gtest, I already set up some for our proposed shared library between OpenRCT2 and OpenLoco:
https://github.com/IntelOrca/libsawyer/

[janisozaur]

I introduced google test to openrct2 and at the time the 1.8.0 release was still fresh. I think gtest does a fine job of providing test framework and has some unique capabilities (like death tests). I ran into some minor issues with gtest which I tried to fix upstream, but it looks like the project is all but abandoned, don't be fooled by the commits that are being made to the googletest repository, they're all for gmock.

For this reason I would consider switching to Catch2, which has matured a lot since the time unit testing was introduced to openrct2.

I'm fine if the test frameworks differ between the two repos, time has shown we don't touch the test code as often for this to be a major problem and we never used the benefits that only gtest provides. That said, gtest is still a strong contender, it does it's job perfectly fine.

[IntelOrca]

I unit test frameworks for C++ are just horrible but there is nothing we can do about that. I am fine with whatever.

I don't know if there is a VS test adaptor for Catch2 though where as there is one for gtest.

[LeftofZen]

I'd love to add some unit testing, does anyone have updated thoughts on GTest vs Catch2, or any other test framework?

Personally I've used GTest before at a previous workplace and haven't used Catch2 before, but I don't have a preference on which framework we use.

Glancing at their respective GitHub pages, they both used a similar macro-style way of declaring tests, both have VS test adapters, both are being updated reasonably frequently. GTest does have way more documentation than Catch2 though.

[LeftofZen]

Easy, I'll try submit a PR some time over the weekend to add GTest

[AaronVanGeffen]

Closing this, as we have introduced the GTest framework and started adding tests for particular modules since.