Export defaults package to the kruise-api repo about kruise

[furykerry]

it may not be the best solution to determine whether the cloneset is reconciled or not. The defaulting logics are the implementation detail of openkruise. For example, SetDefaultsCloneSets will reference the package "k8s.io/kubernetes/pkg/apis/core/v1" not just "k8s.io/api/core/v1". And if there is other mutating webhook that alter cloneset object, the logic also breaks. Maybe one solution is to record the update cloneset spec in the cloneset annotation or other CR.

[ahmetb]

I think it is not an internal implementation detail. It's standard practice to offer such a method just like core APIs do.

We already disable PodTemplate defaulting feature gate on Kruise, so realistically we're only interested in the Kruise-specific fields.

As you noted, this defaulting won't be guaranteed and susceptible to library version vs API version drifts but we'll take it. :)

[manan1979]

I want to try to solve this issue, can you assign it to me ?

[ahmetb]

We can actually close this issue. I realized this pkg imports k8s.io/kubernetes module, which is a massive pain in the back to import in any Go project.