Comments (4)
I think the ability to disable providers at runtime is going to be a short term problem, while OpenYOLO is still not fully baked. That said, providing some guidelines as to how to do this, preferably without changing the protocol, would be wise. I would opt for option 1 from your possible solutions.
from openyolo-android.
We did get the same issue on our end. If a user is not logged in, we didn't want to propose ourself as a possibility for save or hint.
But as you mentioned on the option 2, the latency is huge and I don't think it's worth it.
For now I think we are going to handle option 1 by either propose of the user to logged in (but it will break the flow of the third party app) or by just saying "We cannot do that until you logged in yourself".
from openyolo-android.
It seems worth considering client/spi versioning (i.e. is my client compatible with a given credential provider) when thinking about this issue. The two problems are very similar and may share a solution.
from openyolo-android.
I believe solution 1: Enable/disable OpenYOLO components via PM.setComponentEnabledSetting(), should be the approach recommended.
from openyolo-android.
Related Issues (20)
- Document interactions with Android O's Autofill HOT 15
- CredentialClient.getDeleteResult() should be getCredentialDeleteResult()
- Gradle Error when following the getting started guide when using Android Studio 2.x HOT 1
- Potential security vulnerability in passing Intents via BBQ HOT 6
- Remove backwards compatibility with old BBQ retrieve Intents HOT 2
- Cleanup: utilize ProviderResolver in CredentialClient
- Feedback on demo app HOT 5
- Library uses Java 8 which makes integration difficult HOT 4
- Android Studio auto complete shows Protobuf package too HOT 2
- Proguard exclusion is too broad HOT 2
- Demo app is not working as intended HOT 2
- Confusing behaviuor or bug in providers? HOT 6
- Helper method to find out is any supported provider available? HOT 3
- Test app OpenYOLO Get credential button not working HOT 1
- Tapping the provider picker quickly after it is shown causes it to be dismissed HOT 1
- Crash due to IncompatibleClassChangeError: org.hamcrest.core.IsNull HOT 2
- Crash java.lang.ExceptionInInitializerError HOT 1
- RuntimeException in sample code HOT 1
- Can't delete credentials in Google Smart Lock HOT 1
- Unknown retrieve response in Test app HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openyolo-android.