Stackoverflow when marshalling object about chronicle-wire

[epickrram]

Hi @benwimpory
if you can supply a test case that demonstrates the problem, then please do. The library should work in the situation you describe (or at least fail with a reasonable message).

[benwimpory]

@epickrram Unit test that demonstrates the issue...

package wireobject;

import net.openhft.chronicle.queue.ChronicleQueue;
import net.openhft.chronicle.queue.ExcerptAppender;
import net.openhft.chronicle.queue.impl.single.SingleChronicleQueueBuilder;
import net.openhft.chronicle.wire.DocumentContext;
import org.junit.Test;

import java.io.Serializable;
import java.util.ArrayList;
import java.util.List;

public class WireObjectTest
{
    @Test(expected = StackOverflowError.class)
    public void shouldAppendBToQueue()
    {
        final B b = new B(new ArrayList<>(10), 2);

        final ChronicleQueue queue = SingleChronicleQueueBuilder.binary("/tmp/testqueue").build();
        final ExcerptAppender appender = queue.acquireAppender();

        try (DocumentContext ctx = appender.writingDocument())
        {
            ctx.wire().getValueOut().object(b);
        }
    }
}

class A implements Serializable
{
    private List<B> listOfB;

    public A(List<B> listOfB)
    {
        this.listOfB = listOfB;
    }

    public List<B> getListOfB()
    {
        return listOfB;
    }
}

class B extends A
{
    private int x;

    public B(List<B> listOfB, int x)
    {
        super(listOfB);
        this.x = x;
    }

    public int getX()
    {
        return x;
    }
}

[epickrram]

Thanks for the test case, this issue will be prioritised and fixed in due course.

[RobAustin]

This use case is not currently supported and is not simple to fix, as chronicle-wire first builds its data structures then propagates them with data, see

see net.openhft.chronicle.wire.Wires#writeMarshallable(java.lang.Object, net.openhft.chronicle.wire.WireOut)

    public static void writeMarshallable(@NotNull Object marshallable, @NotNull WireOut wire) {
        WireMarshaller wm = WireMarshaller.WIRE_MARSHALLER_CL.get(marshallable.getClass());
        wm.writeMarshallable(marshallable, wire);
    }

( As I know you are aware ) The problem with your test case, is although your data is not recursive, your data structure ( used by chronicle-wire for mapping your data off heap ) is, and chronicle-wire gets a stack overflow building your data structure.

Thanks for reporting this issue if you required this issue to be fixed promptly please consider purchasing a support contract by contacting [email protected].

Chronicle-Wire does not currently support this use case and as such - We going to mark this as wont fix. If however you would like it fixed, please purchase a support contract.

I thank you again for reporting this issue and sorry that we are not able to fix it on this occasion.

[peter-lawrey]

As yet Wire only supports trees of objects not graphs. ᐧ

…

On 2 January 2018 at 16:37, Rob Austin ***@***.***> wrote: Closed #53 <#53>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#53 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBU8a6HALZyHK1CKCgGXIKqMAVbZO8Xks5tGls9gaJpZM4Pye_p> .