Comments (3)
The issue is that SimpleMDE (used during editing) enables strikethrough by default, while the Laravel-Markdown CommonMark wrapper library (used for viewing the doc) does not support strikethrough.
From the SimpleMDE config guide...
strikethrough: If set to false, will not process GFM strikethrough syntax. Defaults to true.
The Markdown and CommonMark specs do not mention strikethrough/strikeout at all.
So it seems our options are:
- Disable SimpleMDE strikethrough, or
- Enable Laravel-Markdown strikethrough via a CommonMark extension such as commonmark-ext
I'd be happy to work on this but would appreciate guidance from the group. Which option makes the most sense? Should Madison stick closer to the Markdown spec or support common extensions like strikethrough?
from madison.
Do you have any thoughts on this @sethetter?
from madison.
@dbiere apologies for the delay! I think it's sufficient to simply disable the SimpleMDE strike through. We haven't seen too many attempted uses of the feature and can always add to it later.
from madison.
Related Issues (20)
- email notifications - sendgrid HOT 4
- edit /user/sponsor HOT 7
- ZeroClipboard.js: No such file or directory
- Chrome v.55 shows lables
- Anchoring of sidebar annotations on tables breaking HOT 3
- Add link to OpenGov Foundation website to footer image HOT 1
- Database problem HOT 3
- move database when upgrading to 4.0
- Page view county HOT 1
- Cheatsheet for install ubuntu 14 - 64 bits
- Trouble uploading PDF Ordinance HOT 1
- [FEATURE-REQUEST] Feedback either shouldn't be submitted with `return` key or it should allow a 30-second-window for the current IP address to edit the comment upon submission
- Include publishing entity in email notifications
- Small typo HOT 1
- Delete test comments
- Password reset redirects to 404 HOT 1
- Engagement Guide is offline
- Distribution
- Source code
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from madison.