Coder Social home page Coder Social logo

Comments (3)

dbiere avatar dbiere commented on September 27, 2024

The issue is that SimpleMDE (used during editing) enables strikethrough by default, while the Laravel-Markdown CommonMark wrapper library (used for viewing the doc) does not support strikethrough.

From the SimpleMDE config guide...

strikethrough: If set to false, will not process GFM strikethrough syntax. Defaults to true.

The Markdown and CommonMark specs do not mention strikethrough/strikeout at all.

So it seems our options are:

  1. Disable SimpleMDE strikethrough, or
  2. Enable Laravel-Markdown strikethrough via a CommonMark extension such as commonmark-ext

I'd be happy to work on this but would appreciate guidance from the group. Which option makes the most sense? Should Madison stick closer to the Markdown spec or support common extensions like strikethrough?

from madison.

dbiere avatar dbiere commented on September 27, 2024

Do you have any thoughts on this @sethetter?

from madison.

sethetter avatar sethetter commented on September 27, 2024

@dbiere apologies for the delay! I think it's sufficient to simply disable the SimpleMDE strike through. We haven't seen too many attempted uses of the feature and can always add to it later.

from madison.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.