Replace the sink.ref in events api with function ingress about openfunction

[arugal]

Hi @tpiperatgod @benjaminhuo I'd like to try :)

[benjaminhuo]

What does sink.ref looks like now?

[tpiperatgod]

like this:

      apiVersion: serving.knative.dev/v1
      kind: Service
      name: serving-d2blp-ksvc-2hbp6
      namespace: default

[benjaminhuo]

like this:

      apiVersion: serving.knative.dev/v1
      kind: Service
      name: serving-d2blp-ksvc-2hbp6
      namespace: default

The sink could be function, not knative service
It's more user friendly to user maybe

[tpiperatgod]

The solutions are as follows:

type SinkSpec struct {
	Ref *Reference `json:"ref,omitempty"`
	Uri *string    `json:"uri,omitempty"`
}

type Reference struct {
	Kind       string `json:"kind"`
	Namespace  string `json:"namespace,omitempty"`
	Name       string `json:"name"`
	APIVersion string `json:"apiVersion"`
}

Reference provides references to Knative Service and Function resources from which to retrieve function URLs
Uri is used to pass the URL directly

When using the Sink, you must use one of these attributes, and in priority Uri > Reference

Another approach is to deprecate the reference to the Knative Service and use only the Function:

type SinkSpec struct {
	// Namespace of the Function
	Namespace string `json:"namespace,omitempty"`
	// Name of the Function
	Name string `json:"name"`
}

[benjaminhuo]

@arugal That's great!

[benjaminhuo]

The solutions are as follows:

type SinkSpec struct {
	Ref *Reference `json:"ref,omitempty"`
	Uri *string    `json:"uri,omitempty"`
}

type Reference struct {
	Kind       string `json:"kind"`
	Namespace  string `json:"namespace,omitempty"`
	Name       string `json:"name"`
	APIVersion string `json:"apiVersion"`
}

Reference provides references to Knative Service and Function resources from which to retrieve function URLs Uri is used to pass the URL directly

When using the Sink, you must use one of these attributes, and in priority Uri > Reference

Another approach is to deprecate the reference to the Knative Service and use only the Function:

type SinkSpec struct {
	// Namespace of the Function
	Namespace string `json:"namespace,omitempty"`
	// Name of the Function
	Name string `json:"name"`
}

Sounds good!

[tpiperatgod]

I prefer the first solution because it might be a bit more generic 🤔 what do you think?

[arugal]

The solutions are as follows:

type SinkSpec struct {
	Ref *Reference `json:"ref,omitempty"`
	Uri *string    `json:"uri,omitempty"`
}

type Reference struct {
	Kind       string `json:"kind"`
	Namespace  string `json:"namespace,omitempty"`
	Name       string `json:"name"`
	APIVersion string `json:"apiVersion"`
}

Reference provides references to Knative Service and Function resources from which to retrieve function URLs Uri is used to pass the URL directly

When using the Sink, you must use one of these attributes, and in priority Uri > Reference

@tpiperatgod Is this?

[tpiperatgod]

The solutions are as follows:

type SinkSpec struct {
	Ref *Reference `json:"ref,omitempty"`
	Uri *string    `json:"uri,omitempty"`
}

type Reference struct {
	Kind       string `json:"kind"`
	Namespace  string `json:"namespace,omitempty"`
	Name       string `json:"name"`
	APIVersion string `json:"apiVersion"`
}

Reference provides references to Knative Service and Function resources from which to retrieve function URLs Uri is used to pass the URL directly
When using the Sink, you must use one of these attributes, and in priority Uri > Reference

@tpiperatgod Is this?

yes

[benjaminhuo]

The first one looks ok

[arugal]

https://github.com/OpenFunction/OpenFunction/blob/main/controllers/events/event.go#L177

When the URI is set, use ts-%s ts-{resourceName} as the component name template, what do you think? @tpiperatgod @benjaminhuo

[tpiperatgod]

https://github.com/OpenFunction/OpenFunction/blob/main/controllers/events/event.go#L177

When the URI is set, use ts-%s ts-{resourceName} as the component name template, what do you think? @tpiperatgod @benjaminhuo

I think it's ok.

[benjaminhuo]

https://github.com/OpenFunction/OpenFunction/blob/main/controllers/events/event.go#L177

The component's namespace could also be the same as the EventSource(resource)