Coder Social home page Coder Social logo

Comments (6)

benjaminhuo avatar benjaminhuo commented on May 29, 2024

Thanks @zhaibian, this is a very good proposal.
Currently we've pod template and keda scaled object defined and user can control min/max replica by setting these params.

But we might need a more direct way to specify the min/max replicas, @tpiperatgod @wanjunlei what do you think?

from openfunction.

zhaibian avatar zhaibian commented on May 29, 2024

Got your idea. This is my thinking:

  1. keda can be defined at scaled object spec
  2. but knative need to define using annotations ways which openfunction serving has not supported

Even it works, different ways to define the same ability which is not graceful.
Uniform definition ways is better to mask the underlying complexity.

from openfunction.

benjaminhuo avatar benjaminhuo commented on May 29, 2024

zhaibian

Got your idea. This is my thinking:

  1. keda can be defined at scaled object spec
  2. but knative need to define using annotations ways which openfunction serving has not supported

Even it works, different ways to define the same ability which is not graceful. Uniform definition ways is better to mask the underlying complexity.

Agree, a unified definition to min/max replicas is needed.
@wenchajun would you write a proposal for this and then create a PR?

from openfunction.

wenchajun avatar wenchajun commented on May 29, 2024

Agree, a unified definition to min/max replicas is needed.
@wenchajun would you write a proposal for this and then create a PR?

Ok, I'll finish it.

from openfunction.

tpiperatgod avatar tpiperatgod commented on May 29, 2024

I would prefer to add a new property to spec.serving in function cr to support this feature, as it is a feature of the serving phase.

At the same time, we may also need to consider the design of the annotation section to provide the ability to support new features in an annotated form in the future.

from openfunction.

wenchajun avatar wenchajun commented on May 29, 2024

I have written a proposal, please see https://hackmd.io/A-r2frbVTpiDhpfNc7ac2w. We can discuss and complete it.

from openfunction.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.