Barebones setup about openfe

[dwhswenson]

By default I think it's just running pycodestyle. pep8speaks has a custom YAML config for pycodestyle; default here. You can get similar information from pylint or flake8.

I use pylint locally (when I remember). I think pep8speaks only errors on official errors (codes that start with E). (EDIT: actually, I use pylint by way of Syntastic.)

[IAlibay]

pep8speaks is up - didn't customize for now (MDA just uses the base version and just has an annoying bot tell you off for PEP8 violations) - if you feel like customizing please see:
https://github.com/OrkoHunter/pep8speaks?installation_id=22593205&setup_action=install#configuration

[dwhswenson]

What are we thinking for linters other than pep8speaks? Do we need anything else?

IMO, that's all we need in terms of something directly integrated into GitHub. Personally, I like to use CodeClimate to check complexity/repetition (goes beyond linting!), but I don't think it needs to be a hoop for contributors to jump through. I'll enable it on my fork to keep an eye on potential technical debt. I also like to run pylint occasionally, but I don't think we need to enforce style on all the pylint warnings.

[mikemhenry]

Is there a way to run pep8speaks locally? If we are not using a linter that also takes care of formatting automatically, then it's nice to have something that I can run local before I push.

[mikemhenry]

Okay cool, we should probably then include the config that pep8speaks uses so that we get the same errors and warning locally as we do with the bot.

[mikemhenry]

We should also add a CONTRIBUTING file, is there something that OMSF is using for this?

[dwhswenson]

Okay cool, we should probably then include the config that pep8speaks uses so that we get the same errors and warning locally as we do with the bot.

Sorry, my writing wasn't clear: pep8speaks has a YAML config for itself; the link was to the default values. pycodestyle uses a section in setup.cfg. But I think the pep8speaks default is basically what you get with no config for pycodestyle.

We should also add a CONTRIBUTING file, is there something that OMSF is using for this?

Checked a couple OpenFF repos; didn't see anything. No strong opinions from me on CONTRIBUTING files.

[IAlibay]

We should also add a CONTRIBUTING file, is there something that OMSF is using for this?

I would say maybe we need to kick this up the chain of command? I know Karmen mentioned that they were working on some CLAs for OMSF projects. @richardjgowers would know better here.

[IAlibay]

Moving CONTRIBUTING.md to it's own issue - as per slack, close for now.