Comments (8)
Hey @christad92 turns out that this is actually a Lightning issue. The error strings are coming from the Lightning backend
I've tightened up a few things in CLI deploy and i's been worth checking, but I'm going to have to hand this one over to a grown up now
from lightning.
@midigofrank This isn't so much about missing names
Lightning is already running a bunch of validation in lib/lightning/workflows/job.ex :: validate()
. Stuff like checking what characters are in the name string, ensuring an adaptor is set.
We just need to append some kind of pathing information into the message.
Maybe check this slack thread for a bit more context
from lightning.
This is also impacting debugging GH sync failures of existing projects on app
from lightning.
Hi @ritazagoni - I've been meaning to get to this all week. It's sort of been second on my list every day 😬
I think it's an easy fix, I'll get on it
from lightning.
@josephjclark will the cli still make a request to the server if the workflow and job names are missing from the yaml?
Without the names in the params, the backend won't be quite helpful either 😬 .
If they're editing an existing workflow/job, then yes, but for a new workflow / job, I don't see a way
from lightning.
@christad92 I haven't been able to format the error messages as in the description. What I have been able to do is group the error messages based on the workflow/job/trigger/edge
name. For example:
Previous
{
"errors": {
"workflows": [
{
"jobs": [
{
"body": ["Code editor cannot be empty."]
}
]
}
]
}
}
NOW:
{
"errors": {
"workflows": {
"workflow-one": {
"jobs": {
"first-job": {
"body": ["Code editor cannot be empty."]
}
}
}
}
}
}
Can this suffice?
from lightning.
As for edges, the key will be source_job->target_job
as it is in the yaml file
from lightning.
@midigofrank I think this will be fine. I'll try and test against this against your branch and comment in the PR
from lightning.
Related Issues (20)
- Internal Server Error: reload inspector on a step that's been executed twice in one run
- Two regressions "snap-to-logs" for Inspector view
- Toggle on/off console.log() statements in run logs
- Control log levels in run logs
- Support adaptors with version @next HOT 3
- Work out a better way to populate the adaptor list HOT 2
- Show the Owner of a credential on the credentials table
- Don't require ws-worker keys to run migrations in prod
- Standardize button styles and behaviour HOT 2
- Update Email Copies on Lightning
- Allow users to be able to fit their workflows into their view
- Rate limiting on webhook requests HOT 1
- Workflow Diagram: remove node text at low zoom levels
- Workflow diagram: contextual min zoom
- openfn/ws-worker:latest pulls openfn/ws-worker:v0.2.12
- Jumpy cursor in job editor
- Track down duplicate ID errors
- Newly created workflow doesn't run HOT 3
- Deleted workflows cannot be edited or switched to latest
- Can't create a new work order via webhook event, inspector, or history page
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightning.